270342 - In <threadPane.js>, "Warning: function MsgSortThreadPane does not always return a value" and "Warning: function MsgToggleThreaded does not always return a value"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041116] (nightly) (W98SE)

{{
Warning: function MsgSortThreadPane does not always return a value
Source File: chrome://messenger/content/threadPane.js
Line: 303
Source Code:
}

Warning: function MsgToggleThreaded does not always return a value
Source File: chrome://messenger/content/threadPane.js
Line: 331
Source Code:
}
}}

Steps:
1. Open MailNews.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <threadPane.js>

Comment 2

[Serge Gautherie (:sgautherie)]

'blocking1.8a5=?': no big deal, but so easy to fix... (with proposed patch)

Comment 3

[[e-mail]]

Comment on attachment 166201 [details] [diff] [review]
(Av1) <threadPane.js>

>     if (viewFlags & nsMsgViewFlagsType.kGroupBySort)
>     {
>       viewDebug("switching view to all msgs\n");
>-      return SwitchView("cmd_viewAllMsgs");
>+      SwitchView("cmd_viewAllMsgs");
>     }
> 
>-
>     dbview.sort(dbview.sortType, dbview.sortOrder);
>     UpdateSortIndicators(dbview.sortType, dbview.sortOrder);
> }
These changes won't work. The idea is not to do anything after switching the
view. You could do this in at least two ways; one way would be to readd the
return but on its own line; the second way would be to wrap the following lines
in an else block.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <threadPane.js>

Av1, with comment 3 suggestion(s).

Comment 5

[[e-mail]]

Comment on attachment 168058 [details] [diff] [review]
(Av2) <threadPane.js>

>   var viewFlags = dbview.viewFlags;
>-  dbview.viewFlags &= ~ nsMsgViewFlagsType.kGroupBySort;
>   if (viewFlags & nsMsgViewFlagsType.kGroupBySort)
>   {
>+    dbview.viewFlags &= ~ nsMsgViewFlagsType.kGroupBySort;
That's an interesting optimization but now viewFlags is only used once
immediately after calculating it which is a waste, you could just use
dbview.viewFlags directly. Nit: you don't need to add a space after each ~
symbol.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av2b) <threadPane.js> [Checked in: Comment 7]

Av2, with comment 5 suggestion(s).

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 168078 [details] [diff] [review]
(Av2b) <threadPane.js>
[Checked in: Comment 7]


Check in: { 2004-12-07 15:51	neil%parkwaycc.co.uk	mozilla/ mailnews/
base/ resources/ content/ threadPane.js      1.79 }

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 168078 [details] [diff] [review]
(Av2b) <threadPane.js>
[Checked in: Comment 7]

[Mozilla Thunderbird, version 1.0.1 (20050309)] (nightly) (W98SE)

Unexpectedly, this is welcomed on TB branch too...