270377 - nullplugin dialog should only show on left mouse button click

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Vincent Caron]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041007 Galeon/1.3.18 (Debian package 1.3.18-1.1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041007 Galeon/1.3.18 (Debian package 1.3.18-1.1)

The default Mozilla plugin (nullplugin) will pop a dialog (This page [...] can
only be viewed with the appropriate Plug-in) upon release of any mouse button.
Under X11, this has the unwanted effect to be triggered by mouse wheel events:
if one scrolls vertically through a document and an unsupported plugin element
happens to slip under the mouse pointer, the scrolling stops and the spurious
dialog pop.

Attached is a 3-line fix which restricts the popup to Button1 (ie. 'select', aka
left mouse button).

Reproducible: Always
Steps to Reproduce:
1. Try to view a page wich embeds an unsupported plugin
2. Hover the default plugin instance with your mouse pointer and use the mouse wheel

Actual Results:  
A modal dialog pops up.


Expected Results:  
The dialog should only pop on left mouse button release.

I will attach the patch to this bug, it applies to
.mozilla/modules/plugin/samples/default/unix/nullplugin.c from CVS trunk.

Comment 1

[Vincent Caron]

Attachment: restrict dialog popup to left mouse button release

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 166222 [details] [diff] [review]
restrict dialog popup to left mouse button release

Brian, does this look ok to you?

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 271704 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.8b.

Vincent, in general you want to request review for your patches (see
http://www.mozilla.org/hacking/life-cycle.html and
http://www.mozilla.org/owners.html) and when they have reviews it's a good idea
to ping someone to check them in.  Keeps them from getting lost.  ;)