270399 - Compilation error in nsXPCOMGlue.cpp

Status: VERIFIED WORKSFORME

(Core :: XPCOM, defect)

Description

[Adam D. Moss]

After updating my firefox trunk tree (hadn't done so for a week or so), my build
attempts fail with the following:

gmake[5]: Entering directory `/snout/firefoxsrc/mozilla/xpcom/glue/standalone'
nsXPCOMGlue.cpp
g++31 -o nsXPCOMGlue.o -c -DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DXPCOM_GLUE
-DMOZILLA_STRICT_API -I./../../build  -I../../../dist/include/string
-I../../../dist/include/xpcom -I../../../dist/include
-I/snout/firefoxsrc/mozilla/dist/include/nspr     -I/usr/X11R6/include   -fPIC 
-I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe 
-DNDEBUG -DTRIMMED -O2 -march=k6-2 -mcpu=athlon  -I/usr/X11R6/include 
nsXPCOMGlue.cpp
nsXPCOMGlue.cpp: In function `nsresult XPCOMGlueStartup(const char*)':
nsXPCOMGlue.cpp:94: parse error before `,' token
nsXPCOMGlue.cpp:109: parse error before `;' token
nsXPCOMGlue.cpp: At global scope:
nsXPCOMGlue.cpp:145: parse error before `if'
nsXPCOMGlue.cpp:148: warning: ISO C++ forbids declaration of `rv' with no type
nsXPCOMGlue.cpp:149: parse error before `if'
nsXPCOMGlue.cpp:152: warning: ISO C++ forbids declaration of `
   GRE_AddGREToEnvironment' with no type
nsXPCOMGlue.cpp:152: new declaration `int GRE_AddGREToEnvironment()'
nsXPCOMGlue.cpp:54: ambiguates old declaration `void GRE_AddGREToEnvironment()'
nsXPCOMGlue.cpp:153: parse error before `return'
nsXPCOMGlue.cpp:155: syntax error before `:' token
nsXPCOMGlue.cpp:157: warning: ISO C++ forbids declaration of `xpcomLib' with no 
   type
nsXPCOMGlue.cpp:157: conflicting types for `int xpcomLib'
nsXPCOMGlue.cpp:60: previous declaration as `PRLibrary*xpcomLib'
nsXPCOMGlue.cpp:158: warning: ISO C++ forbids declaration of `memset' with no 
   type
nsXPCOMGlue.cpp:158: `int memset' redeclared as different kind of symbol
/usr/include/string.h:55: previous declaration of `void* memset(void*, int, 
   unsigned int)'
nsXPCOMGlue.cpp:158: warning: initializer list being treated as compound 
   expression
nsXPCOMGlue.cpp:159: parse error before `return'
nsXPCOMGlue.cpp: In function `nsresult XPCOMGlueShutdown()':
nsXPCOMGlue.cpp:173: warning: invalid conversion from `int' to `PRLibrary*'
nsXPCOMGlue.cpp:177: `memset' cannot be used as a function
nsXPCOMGlue.cpp: In function `void GRE_AddGREToEnvironment()':
nsXPCOMGlue.cpp:470: new declaration `void GRE_AddGREToEnvironment()'
nsXPCOMGlue.cpp:152: ambiguates old declaration `int GRE_AddGREToEnvironment()'
gmake[5]: *** [nsXPCOMGlue.o] Error 1
gmake[5]: Leaving directory `/snout/firefoxsrc/mozilla/xpcom/glue/standalone'

A 'make clobber' doesn't help.  This is GCC 3.1.1.

Comment 1

[Adam D. Moss]

Probably caused by this checkin:
2004-11-15 20:44 darin%meer.net 'fixes bug 264274 "support dependent strings in
frozen string API" r=biesi sr=bsmedberg'

I'll back that patch out and try a recompile.

Comment 2

[Adam D. Moss]

Hm, actually the '1.2' patch on that bug doesn't reverse-apply to the trunk
properly.  

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

you can try bonsai's "show commands which can be used to backout these patches"
feature

Comment 4

[Darin Fisher]

-> me

Comment 5

[Adam D. Moss]

Although 'make clobber' didn't help, in desparation I eventually tried 'make
distclean' and the build subsequently went okay!
-> resolved.

Comment 6

[Darin Fisher]

v