270404 - sendbugmail.pl doesn't work

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Nick Barnes]

the contrib/sendbugmail.pl script which we added to fix bug 239343 is a little
broken, at least with the version of Perl I have installed here.

1. It puts .. on PERL's @INC path, but that doesn't actually work.  If I invoke
from the contrib directory then it can't find some stuff:

  $ perl -T sendbugmail.pl 1 [e-mail]
  No value for param loginmethod (try running checksetup.pl again) at
../Bugzilla/Config.pm line 161.
  BEGIN failed--compilation aborted at ../Bugzilla/Auth.pm line 42.
  Compilation failed in require at ../Bugzilla.pm line 27.
  BEGIN failed--compilation aborted at ../Bugzilla.pm line 27.
  Compilation failed in require at ../globals.pl line 1667.
  BEGIN failed--compilation aborted at ../globals.pl line 1667.
  Compilation failed in require at sendbugmail.pl line 19.
  $ 

and if I invoke from the main directory then it can't find anything:

  perl -T contrib/sendbugmail.pl 1 [e-mail]
  Can't locate Bugzilla/BugMail.pm in @INC (@INC contains: ..
/usr/local/lib/perl5/site_perl/5.6.1/mach /usr/local/lib/perl5/site_perl/5.6.1
/usr/local/lib/perl5/site_perl/5.005/i386-freebsd
/usr/local/lib/perl5/site_perl/5.005 /usr/local/lib/perl5/site_perl
/usr/local/lib/perl5/5.6.1/BSDPAN /usr/local/lib/perl5/5.6.1/mach
/usr/local/lib/perl5/5.6.1) at ./contrib/sendbugmail.pl line 20.
  BEGIN failed--compilation aborted at ./contrib/sendbugmail.pl line 20.
  $

2. In taint mode, it fails because we don't detaint the first parameter (the bug
number): 

  $ perl -T contrib/sendbugmail.pl 1 [e-mail]
  Insecure dependency in parameter 1 of DBI::db=HASH(0x85a664c)->prepare method
call while running with -T switch at Bugzilla/DB.pm line 60.
  $

3. The usage comment at the head refers to the script as bugmail, not sendbugmail.

I have a patched version, and will attach it.

Comment 1

[Nick Barnes]

Attachment: patched sendbugmail.pl

Comment 2

[Nick Barnes]

Attachment: patch to sendbugmail.pl from 2.18rc3

Comment 3

[Nick Barnes]

The attached patch (attachment 166231 [details] [diff] [review]) simply changes the existing (2.18rc3)
contrib/sendbugmail.pl into the attached one (attachment 166230 [details]).

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 166231 [details] [diff] [review]
patch to sendbugmail.pl from 2.18rc3

Looks good to me

Comment 5

[Nick Barnes]

Thanks for moving so quickly on this, guys.  What happens next?  Does "review+"
mean that it's been reviewed and found OK?  The bug is assigned to me but I
can't do anything with it because I don't have CVS write access.  What's the
procedure here?

Comment 6

[Vlad Dascalu]

Checking in contrib/sendbugmail.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/sendbugmail.pl,v  <--  sendbugmail.pl
new revision: 1.2; previous revision: 1.1
done

Checking in contrib/sendbugmail.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/sendbugmail.pl,v  <--  sendbugmail.pl
new revision: 1.1.2.1; previous revision: 1.1
done

(In reply to comment #5)
> Thanks for moving so quickly on this, guys.  What happens next?  Does "review+"
> mean that it's been reviewed and found OK?  The bug is assigned to me but I
> can't do anything with it because I don't have CVS write access.  What's the
> procedure here?

If you don't have CVS write access someone will check it in for you :) (like me,
for example - I have a query that returns pending bugs that are approved but
still opened, and I commit those to CVS if the name of the assignee doesn't
indicate a person with CVS write access)

Review+ means that the code was reviewed and found ok. To be checked in, the
patch needs approval from justdave or myk, which means one of those two gave
their "stamp" for code integration with the rest of the code-base.