27041 - ALT key causing menu loop to be entered on Win32

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[David Hyatt]

Keyboard navigation in menus has been regressed on Win32.  I'm not sure exactly 
when it happened, so I'm cc'ing all people that might have touched this code.

What's going wrong: The ALT key was originally being trapped, and we were not 
allowing Win32 to know about the press, since if it found out about the press it 
would enter a native menu loop.

This was working for a long time, and now it seems the ALT press is being 
allowed in to Win32, and so the system starts stealing key presses instead of 
the XP menus.

This breaks keyboard navigation in menus.  Nominating as both beta1 and dogfood.

Comment 1

[David Hyatt]

Assigning to rod, since I suspect a menu exorcism/cleanup might have caused 
this.

Comment 2

[leger]

Moving dogfood and regression to keyword field.

Comment 3

[rods (gone)]

This work fine for me today. When I do ALT-F the file menu drops down. 

Comment 4

[David Hyatt]

That doesn't put you into the native menu loop.  The trick testing this is to 
hit the ALT key by itself and then hit the down arrow key.  What you'll see is 
that you've entered the native menu loop, and when you hit the down arrow, 
you'll be in the system menu!

When you hit the shortcut key+ALT key, you're ok.  It's when you hit the ALT key 
by itself to activate the menu that you hit the regression.

Comment 5

[rods (gone)]

Thanks for the test sugestion.

I have a fix. 

Yes, I removed a little too much code.

Comment 6

[rods (gone)]

fixed

Comment 7

[sairuh (rarely reading bugmail)]

verif on winNT w/opt comm bits, 2000022808.