270453 - Alter ampersands in CNET link to validate properly.

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Reed Wiedower]

The current link to a CNET article is not valid...the link code is:
http://reviews.cnet.com/Mozilla_Firefox_1_0/4505-9241_7-31117280.html?part=editchoice&subj=Mozilla&tag=logo


It shoud be:
http://reviews.cnet.com/Mozilla_Firefox_1_0/4505-9241_7-31117280.html?part=editchoice&subj=Mozilla&tag=logo

This is causing the default Firefox page not to validate properly.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

fixed

Comment 2

[Reed Wiedower]

I noticed two more validation errors in the CNET links: one, that the link
contains a "target" link which is invalid, and two, that the img associated with
the link has a "border='0'" attributed which is also invalid. 

Thus, 
423:         <a
href="http://reviews.cnet.com/Mozilla_Firefox_1_0/4505-9241_7-31117280.html?part=editchoice&amp;subj=Mozilla&amp;tag=logo"

424:            target="_blank"><img 
425:            src="http://i.i.com.com/cnwk.1d/i/cobd/ec/EC_nov04_39x72.gif" 
426:            width="39" height="72" border="0" 
427:            alt="CNET Editors' Choice, November 2004, Firefox1.0"></a>      
428:

should be:


423:         <a
href="http://reviews.cnet.com/Mozilla_Firefox_1_0/4505-9241_7-31117280.html?part=editchoice&amp;subj=Mozilla&amp;tag=logo">

424:           <img 
425:            src="http://i.i.com.com/cnwk.1d/i/cobd/ec/EC_nov04_39x72.gif" 
426:            width="39" height="72"
427:            alt="CNET Editors' Choice, November 2004, Firefox1.0"></a>      
428:

Changing these two things should finally make the page valid html 4.01 strict.

Comment 3

[Dave Miller [:justdave]]

There's also a meta tag indicating iso-8859-1 charset but the HTTP headers says
utf-8.  The meta tag needs to go away.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

If the HTTP headers say UTF-8, that's probably a sign that one of our webserver
mirrors is misconfigured (default Apache 2 AddDefaultCharset, perhaps), which
would mean that a bunch of our content is broken on that mirror.

Comment 5

[Dave Miller [:justdave]]

(In reply to comment #4)
> If the HTTP headers say UTF-8, that's probably a sign that one of our webserver
> mirrors is misconfigured (default Apache 2 AddDefaultCharset, perhaps), which
> would mean that a bunch of our content is broken on that mirror.

we should be controlling charset with .htaccess files if they differ from the
server-wide charset.

I'm pretty sure current versions of Apache2 default to UTF-8 (and I'd been
planning to set our Apache 1.3 on rheet to mandate it, too).

Comment 6

[Anne (:annevk)]

I fixed this issue mentioned in comment 2. Removing dependecy since that has not
much to do with this bug and will eventually be fixed when we switch to UTF-8
side-wide. (Besides, the page validates perfectly.)

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The removal of the target attribute was a significant change in function.  Did
you ask the original author of that image link if that was what they intended?