Closed Bug 270477 Opened 20 years ago Closed 20 years ago

Land New Update to Qute theme

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird1.0

People

(Reporter: mscott, Assigned: mscott)

Details

Attachments

(14 files)

search toolbar screenshot
63.07 KB, image/png
Details
Windows XP Search Toolbar w/ missing border
36.07 KB, image/jpeg
Details
linux filepicker screenshot - look at the upper-right buttons
34.03 KB, image/png
Details
fix extra white line drawn right above "Folders" header in the folder pane
710 bytes, patch
Details | Diff | Splinter Review
linux filepicker from 2004-11-12 build
31.60 KB, image/png
Details
WinXP Media Center Style, after patch
64.61 KB, image/jpeg
Details
fix for subscribe dialog
4.75 KB, patch
Details | Diff | Splinter Review
screenshot
8.24 KB, image/png
Details
Screenshot of saved-search-folder
10.69 KB, image/png
Details
folder pane showing virtual folders
16.98 KB, image/png
Details
Screenshot of creating saved-search with missing feed-icon
9.05 KB, image/png
Details
Screenshot of creating saved-search with missing unsent-icon
9.34 KB, image/png
Details
move virtual folder CS rules below news CSS rules
2.41 KB, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review
Rules for RSS folder icons in menus
1.38 KB, patch
mscott
: review+
Details | Diff | Splinter Review 
Tracking bug for the theme update
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.0
OS: Windows XP → All
Hardware: PC → All
I just landed the new theme update.

Also note the new account central page with artwork!

I'm sure I broke some things along the way. Feel free to comment here and we'll
fix them in this bug.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Using tinderbox build (Build ID=2004111722):
Two nits:
The toolbars for print preview and the javascript console could use some more
padding between the icons and the text on the buttons.

The checkmarks in the dialogs "Subscribe to Folders", "Folders for Offline use"
and so forth are still those "beautiful" violet Netscape 4.x versions. Couldn't
this be updated as well?
Nit 3:
The search toolbar in the three-pane and address book windows has no top border,
and its height is too small to make the message list and folder panes align
properly. Actually I saw this first when the address book searchBox changes were
made.
I second comment 2!
Thomas, can you attach a screen shot of your search box problem? Linux or
Windows? I don't see it on my machine. The box has the right height and seems to
be lining up correctly.
screenshot taken on linux fc2 using 2004111805-0.9.

Thomas, is this the problem you see in comment 3? there seems to be this
semi-visible vertical border btwn the "Folders" section of the toolbar, just to
the left of the "View" text.
(In reply to comment #2)
> The checkmarks in the dialogs "Subscribe to Folders", "Folders for Offline use"
> and so forth are still those "beautiful" violet Netscape 4.x versions. Couldn't
> this be updated as well?

those odd-skool checkmarks also occur in the "Manage Newsgroup Subscriptions"
and "Select Folder(s)" dialogs (the latter is a subdialog of the Saved Search
Folder dialogs).
Alas, looks spiffy on Linux and Windows, but the Mac shows no new icon for
virtula folders. Sarah suggested reopening this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
scott: however, if you prefer we open a separate bug on the mac issue... :)
Summary: Land New Update to Qute → Land New Update to Qute theme
The Qute theme is Windows and Linux only. Mac uses a completely separate them
called pinstripe. This bug is about landing updates to qute.

It is unknown at this time if the pinstripe guys are going to update the theme
before 1.0. 

re-closing this bug.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
okay, I've spun off bug 270667 for the Mac-only theme case.
This is the issue sairuh sees on Linux, but here on Windows XP. As obvious,
this is a fresh test profile.
Nit 4, WinXP:
The caption bar icons of Address Book and Compose Window are only 16x16 pixels
when shown in the ALT+TAB switcher window, which I guess uses 32x32. This makes
the icons appear "pixelated".

Checking back with contents of chrome\icons\default in a 20041113 zip-nightly,
all four .ico files contained images in 16, 32 and 48 sizes.

I guess we need to contact Arvid to include the larger ones again...
the filepicker on linux (opening or saving files): the "up directory," "home"
and "new directory" buttons in the upper-right have a bit too much whitespace
on the right side on each of them.
Attachment #166475 - Attachment description: filepicker screenshot - look at the upper-right buttons → linux filepicker screenshot - look at the upper-right buttons
the ICO issue has been fixed
sarah, can you attach a screen shot with the file picker from before the theme
update so I can compare the two? thanks!
(In reply to comment #16)
> sarah, can you attach a screen shot with the file picker from before the theme
> update so I can compare the two? thanks!

already did in comment 14. :)
sorry I meant before the theme update. That picture is with the new artwork right? 
> sorry I meant before the theme update. That picture is with the new artwork
right? 

oh, now I understand you. yes, that one's with the current new artwork.
screenshot of what it looked like before coming up...
the images in the icon buttons in the 2004-11-12 build (before Qute update) are
also a bit off-center to my eyes. but I think they're more off-center (more
whitespace on right edge) with the newer Qute theme bits.
yup, looks like the filpicker problem has always been there. It just happens
that the new icons are slightly smaller so it is more noticeable.
We have some more discussion about the search toolbar issue in the forums:
http://forums.mozillazine.org/viewtopic.php?p=985604#985604
This is the main window without the top-border highlight.
Note how the media center style in the attachment doesn't have the gradient
shadow at the main toolbar's border-bottom like the "Windows XP" style. This
makes the search bar look like an ordinary toolbar.

Still, the style rule "height: 30px" (along with the border-top rule) for
#searchBox is somehow overridden, and the folder pane and the searchbox don't
align anymore. Maybe it's OK for 1.0 to reduce the height on the folder pane
header. Although that is curing the symptoms, not the cause.
I just noticed some throbber issues:
Large icons toolbar: throbber in normal state is pretty small. It looks as it
fit's on the menubar as in Firefox. But in active state it becomes large -> the
menubar expands.
The normal state icon for the throbber differs for small and large toolbars.
Actually it is *bigger* for *small* icons. My guess is the intention was to use
the same icon regardless of toolbar size.

I guess we have some old artwork or CSS in here.
(In reply to comment #25)
> Note how the media center style in the attachment doesn't have the gradient
> shadow at the main toolbar's border-bottom like the "Windows XP" style. This
> makes the search bar look like an ordinary toolbar.

Ok I fixed this the right way now. Let me know how it looks in tomorrow's builds
for me. 


Confirming fixed:
searchtoolbars (borders, height)
Message window and Address book large icons (Windows ALT+TAB task switcher)

good work
(In reply to comment #26)
> I just noticed some throbber issues:
> Large icons toolbar: throbber in normal state is pretty small. It looks as it
> fit's on the menubar as in Firefox.

Any reason why the smaller throbber isn't on the menubar like Firefox? It looks
lost sitting on the toolbar at that size.

Also with regard to the new checkbox icons - looking in subscribe newsgroups,
the icons are left aligned in the 'Subscribed' column. They would be better off
centered IMO.
for reference here's the patch for fixing the subscribe dialog which I just
checked in. The label above the subscribe tree changes value based on whether
you are subscribing to news or imap.
Attached image screenshot — 
Found another ugly icon (screenshot attached).
In the create-dialog of the saved-search-folder we can use the new "saved
search"-icon for already created saved searches.
just fixed the issue cited in
https://bugzilla.mozilla.org/show_bug.cgi?id=270477#c32

good catch
just fixed the issue with the bogus icon for offline news articles with
attachments cited in comment #31
https://bugzilla.mozilla.org/show_bug.cgi?id=270477#c31
(In reply to comment #32)
> Created an attachment (id=167119)
> Screenshot of saved-search-folder
> 
> In the create-dialog of the saved-search-folder we can use the new "saved
> search"-icon for already created saved searches.

Also the new feed-icon is missing in a news & blog account.
Also the icon for the "unsent messages" in the local folders is missing.

Sorry, but I found them one by one and not all together :-(
I see a unsent folder icon in local folders


observed using 200411305-0.9 bits on linux: the icon for a virtual folder in a
news account is the same as the one for a regular news icon. screenshot coming up.
"news-virt" is a virtual folder under my news account, and its icon is
identical to the n.p.m.test newsgroup icon. (compare with RSS account and Local
Folders, which does contain unique icons for their virtual folders,
"joey-recent" and "local-virtual," respectively.
Depends on: 272320
No longer depends on: 272320
Comment on attachment 167601 [details] [diff] [review]
move virtual folder CS rules below news CSS rules

This fixes what Sarah saw in:

https://bugzilla.mozilla.org/attachment.cgi?id=167471&action=view

now virtual folders living under news accounts show the saved search icon
instead of a newsgroup icon by moving the virtual folder style rule afer the
news folder CSS.
Attachment #167601 - Flags: superreview?(bienvenu)
Attachment #167601 - Flags: superreview?(bienvenu) → superreview+
the news saved search style fix is checked into the branch and trunk
comment 43 and 44: vrfy'd fixed with 2004120210-0.9 on linux fc2. the saved
search icon for news is now present (same appearance as a virtual folder for a
mail account). thanks, Scott!
You can also see the missing feed-icon as described in comment #40, when you
open a mail and then klick on the "file" button to save the mail in another folder.
(In reply to comment #46)
> You can also see the missing feed-icon as described in comment #40, when you
> open a mail and then klick on the "file" button to save the mail in another
folder.

yes, I also noticed this occurs in:

- File dropmenu in Search Messages
- folder dropmenus in Filter Rules
- Choose dialog for Saved Searches
- Create as subfolder dropmenu for Saved Searches

this also occurs for the Pinstripe theme on Mac.
Comment on attachment 167793 [details] [diff] [review]
Rules for RSS folder icons in menus

Here's a patch for Winstripe to use RSS icons in the menus..seems pretty
simple, but I dont have a Windows box set up to test. Scott, can you check this
out for me if you have time?
Attachment #167793 - Flags: review?(mscott)
Comment on attachment 167793 [details] [diff] [review]
Rules for RSS folder icons in menus

thanks Kevin. I tested and checked this low risk fix into the branch and trunk.

Note, this only changes the icons for menu lists in the main mail window like
the file button.
Attachment #167793 - Flags: review?(mscott) → review+
since newsblog is an extension, should base/skin/folderMenus.css import
newsBlogOverlay.css?
Now the file-button has the rss-icons but the issues from comment #40 & #47 are
still there.

The combobox in "search messages" "search for message in" and the comboboxes in
"filter rules" for "move to folder" & "copy to folder" have no icons. Is it
possible to add them. It's more clear with icons.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: