[s390x] global register variable follows a function definition

RESOLVED INVALID

Status

()

RESOLVED INVALID
14 years ago
14 years ago

People

(Reporter: caillon, Assigned: caillon)

Tracking

Trunk
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Using gcc 3.4.3 20041114, I get:

gmake[8]: Entering directory
`/usr/src/build/484024-s390x/BUILD/mozilla/xpcom/reflect/xptcall/src/md/unix'
xptcinvoke_linux_s390x.cpp
c++ -o xptcinvoke_linux_s390x.o -c -DOSTYPE=\"Linux2.4.21-20\"
-DOSARCH=\"Linux\" -DEXPORT_XPTC_API   -I../../../../../../dist/include/xpcom
-I../../../../../../dist/include
-I/usr/src/build/484024-s390x/BUILD/mozilla/dist/include/nspr     -I./../..
-I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions
-Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic
-fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O  -I/usr/X11R6/include
-DMOZILLA_CLIENT -include ../../../../../../mozilla-config.h
-Wp,-MD,.deps/xptcinvoke_linux_s390x.pp xptcinvoke_linux_s390x.cpp
xptcinvoke_linux_s390x.cpp:181: error: global register variable follows a
function definition
gmake[8]: *** [xptcinvoke_linux_s390x.o] Error 1
gmake[8]: Leaving directory
`/usr/src/build/484024-s390x/BUILD/mozilla/xpcom/reflect/xptcall/src/md/unix'
gmake[7]: *** [libs] Error 2
gmake[7]: Leaving directory
`/usr/src/build/484024-s390x/BUILD/mozilla/xpcom/reflect/xptcall/src/md'
gmake[6]: *** [libs] Error 2
gmake[6]: Leaving directory
`/usr/src/build/484024-s390x/BUILD/mozilla/xpcom/reflect/xptcall/src'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory
`/usr/src/build/484024-s390x/BUILD/mozilla/xpcom/reflect/xptcall'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory
`/usr/src/build/484024-s390x/BUILD/mozilla/xpcom/reflect'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory `/usr/src/build/484024-s390x/BUILD/mozilla/xpcom'
gmake[2]: *** [tier_2] Error 2
gmake[2]: Leaving directory `/usr/src/build/484024-s390x/BUILD/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/usr/src/build/484024-s390x/BUILD/mozilla'
make: *** [build] Error 2
Created attachment 166272 [details] [diff] [review]
Move the declaration to the head of the file
is this error on trunk, on a branch or on both?
(In reply to comment #2)
> is this error on trunk, on a branch or on both?

Firefox 1.0 and Trunk at least.  Presumably 1.7 as well since bug 264326 landed
there too.
then the same patch should be used for xptcinvoke_linux_s390.cpp

But patch for bug 264326 is not in Aviary yet.
Anyway if I could review code you would get the flag from me ;-)
this isn't needed anymore as soon as patch for #272369 lands
now invalid
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.