270497 - getters/setters for attributes in JS components return NS_ERROR_FAILURE in xpcshell

Status: RESOLVED DUPLICATE of bug 239969

(Core :: XPConnect, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

NS_ERROR_FAILURE is thrown when a pure-JS component implements an attribute
using a getter/setter pair.  Stick the attached sampleComp.js in a components
directory and run xpcshell, then:

var e =
Components.classes["@mozilla.org/test/sample;1"].createInstance(Components.interfaces.nsISample);

e.value

The e.value will throw NS_ERROR_FAILURE.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: sampleComp.js

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Note that removing the value getter/setter and changing it to just 'value:
"foo"' causes e.value to work fine.

Comment 3

[Mike Shaver (:shaver emeritus)]

So, this fails because the script security manager can't find the subject principal:

nsresult
nsScriptSecurityManager::CheckPropertyAccessImpl(PRUint32 aAction,

    nsCOMPtr<nsIPrincipal> subjectPrincipal;
    if (NS_FAILED(GetSubjectPrincipal(cx, getter_AddRefs(subjectPrincipal))))
        return NS_ERROR_FAILURE;

So it works in chrome or with UniversalXPConnect, but not in xpcshell.

Didn't this used to work?  Did someone dork with the xpcshell security manager?
 (Same behaviour on aviary, so it wouldn't be recent.)

Comment 4

[timeless]

i think i reported this somewhere, there's a proposed fix lying around somewhere
too.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I wonder if this is the same as
http://groups.google.com/groups?hl=en&lr=&threadm=ced6ui%242cd1%40ripley.netscape.com&rnum=1&prev=/groups%3Fq%3Dmozilla%2Bautoconfig%2Bsetter%26hl%3Den%26lr%3D%26selm%3Dced6ui%25242cd1%2540ripley.netscape.com%26rnum%3D1

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

also see bug 239969

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** This bug has been marked as a duplicate of 239969 ***