Closed Bug 270515 Opened 20 years ago Closed 18 years ago

Smart Keyword Search (bookmark shortcuts): International/non-ascii characters (e.g. umlauts) aren't encoded correctly

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows XP
defect
Not set
major

Tracking

()

RESOLVED DUPLICATE of bug 258223

People

(Reporter: trash17, Unassigned)

References

Details

(Keywords: intl)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Since FF1.0 the smart keyword search doesn't work with umlauts anymore. If you
type "e säge" (when 'e' is defined for
'http://search.ebay.de/search/search.dll?query=%s') then ebay reports "säge"
instead of "säge". this happens on amazon, dict.leo.org, etc...
In FF0.93 the words with special characters are encoded correctly, so i compared
the browser.js of both programs and i found out, that if you replace the line
'shortcutURL = shortcutURL.match(/%s/) ? shortcutURL.replace(/%s/g,
encodeURIComponent(text)) : null;'
with the old line from FF0.93
'shortcutURL = shortcutURL.match(/%s/) ? shortcutURL.replace(/%s/, text) : null;'
all umlauts are encoded correctly again.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
see details
oh goddamn,
sorry for the umlauts again. they were broken in the description. i mean the
pendant for 'ae' 'oe' and 'ue' - ä ö ü
I can confirm this bug on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.7.5) Gecko/20041107 Firefox/1.0.  For more information, see:

http://forums.mozillazine.org/viewtopic.php?t=164217&highlight=

The solution seems to have been posted in that thread as well.
similiar to Bug 265579, Bug 265579, and Bug 251331
(In reply to comment #3)
> similiar to Bug 265579, and Bug 251331

and Bug 246848 too
Keywords: intl
Assignee: p_ch → vladimir+bm
Component: Search → Bookmarks
QA Contact: firefox.search → mconnor
Summary: Smart Keyword Search: Special characters (i.e. umlauts) aren't encoded correctly → Smart Keyword Search (bookmark shortcuts): International/non-ascii characters (e.g. umlauts) aren't encoded correctly
(In reply to comment #4)
> (In reply to comment #3)
> > similiar to Bug 265579, and Bug 251331
> 
> and Bug 246848 too

yes, it is SIMILAR, but for me it is NOT the same bug, because all other "bugs"
with character encoding work for me. i have only the "smart keyword
search"-problem. anyone else?
(In reply to comment #5)
> (In reply to comment #4)
> > and Bug 246848 too
> 
> yes, it is SIMILAR, but for me it is NOT the same bug, because all other "bugs"
> with character encoding work for me. i have only the "smart keyword
> search"-problem.

Bug 246848 is for smart keyword search.
*** Bug 311720 has been marked as a duplicate of this bug. ***
Assignee: vladimir+bm → nobody

*** This bug has been marked as a duplicate of 258223 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.