270589 - t/008filter.t should accept empty template directives

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Marc Schumann [:Wurblzap]]

If you put [%-%] at the beginning of a line in a template, the previous line
continues without a line break with the following text. This is useful to split
up otherwise long source lines.

Unfortunately, t/008filter.t does not like that, and complains. It does like
[%-#%], though, so there is a workaround, but I think it would be nice to be
allowed to use the more elegant notation.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch allowing empty directives

This is motivated by bug 262372 and the comment in filterexceptions.pl
(http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/template/en/default/filterexceptions.pl#139)
about empty directives.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 166323 [details] [diff] [review]
Patch allowing empty directives

Makes sense to me.  I'd like a second review to make sure I'm not out of my
mind though. :)

Comment 3

[Christian Reis]

This looks good to me.

Comment 4

[Marc Schumann [:Wurblzap]]

Btw, [%%] works, too.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 166323 [details] [diff] [review]
Patch allowing empty directives

I'm not that excited about this use of empty directives, but they shouldn't
break the filtering code. r=myk

Comment 6

[Vlad Dascalu]

Checking in t/008filter.t;
/cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v  <--  008filter.t
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v 
<--  filterexceptions.pl
new revision: 1.26; previous revision: 1.25
done