270611 - hardwired sendmail path doesn't work on BSD

Status: RESOLVED WORKSFORME

(Bugzilla :: Email Notifications, defect)

Description

[Nick Barnes]

Bugzilla has a hard-wired path to /usr/lib/sendmail in a bunch of places.  This
Just Doesn't Work on *BSD operating systems (including Mac OS X) and maybe on
others.  It's a small matter to replace this with either a parameter or a
localconfig item.
Sooner or later the email interface will be replaced with something much more
modular and splendid (see bug 84876).  It slices!  It dices!  Maybe it will even
make the tea.  In the meantime, let's spend 10 minutes making Bugzilla work out
of the box on *BSD, without the admin having to make a symlink in /usr/lib.

Comment 1

[Nick Barnes]

Another related bug is 49893, again addressing an important and much larger point.

Comment 2

[Nick Barnes]

Attachment: patch for recent CVS tip.

Here's a patch on a recent CVS tip that sets up $sendmailbin as a localconfig
variable.

Comment 3

[Dave Miller [:justdave]]

Setting $sendmailbin to an empty string on Win32 is probably a Bad Thing. 
You'll wind up with the command line getting executed with the parameters being
the first thing on the command line.  I think the current Win32 setup
instructions that Byron has say to put the mock sendmail binary at
C:\usr\lib\sendmail, which means the Linux default should work on Win32 as well
to make those instructions keep working.  Is that correct, Byron?

Comment 4

[:glob ✱]

that's correct.  on windows the default should be "/usr/lib/sendmail".

while i'm here, you should redirect stderr

  $sendmail_binary = `which sendmail 2>&1`;


is it worth worrying about paths with spaces in them?  (common on win32).

Comment 5

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 6

[Max Kanat-Alexander]

This isn't a problem anymore in modern Bugzilla, since we use Email::Send to send mails, we don't directly use sendmail.