270640 - Implement DOM 3 isDefaultNamespace()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a4) Gecko/20040927
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a4) Gecko/20040927

Summary says all.
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsGenericElement.cpp#489

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

+also for other Nodes, not only for Element.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: For Elements, Attributes, Documents and DocumentFragments

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 166370 [details] [diff] [review]
For Elements, Attributes, Documents and DocumentFragments

 nsNode3Tearoff::IsDefaultNamespace(const nsAString& aNamespaceURI,
				    PRBool* aReturn)
 {
-  NS_NOTYETIMPLEMENTED("nsNode3Tearoff::IsDefaultNamespace()");
-
-  return NS_ERROR_NOT_IMPLEMENTED;
+  *aReturn = PR_FALSE;
+  nsAutoString defaultNamespace;
+  LookupNamespaceURI(EmptyString(), defaultNamespace);
+  if (aNamespaceURI.Equals(defaultNamespace))
+    *aReturn = PR_TRUE;
+  return NS_OK;

You can eliminate that if check and the initalization of *aReturn to PR_FALSE
there if you write this as:

+  nsAutoString defaultNamespace;
+  LookupNamespaceURI(EmptyString(), defaultNamespace);
+  *aReturn = aNamespaceURI.Equals(defaultNamespace);
+  return NS_OK;

r+sr=jst with that change.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: fix

If someone can check this in when the tree is open again.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 6

[Darin Fisher]

Tp on btek regressed ever so slightly after this was checked in.  But, I don't
see anything obvious in this patch that could explain that :-/