270686 - getStatusString() in CMCStatusInfo throws null pointer exception

Status: RESOLVED FIXED

(JSS Graveyard :: Library, defect, P1)

Description

[Wan-Teh Chang]

In the implementation of getStatusString(), it returns
statusString.toString(). If the status string is null,
this function will throw NullPointerException.

We should do the following:
>         if (statusString != null)
>                   return statusString.toString();
>         return null;

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

Comment 2

[Wan-Teh Chang]

Comment on attachment 166373 [details] [diff] [review]
Proposed patch

Glen, please review this patch, and let me know
if I can check it in on the JSS trunk now.

Comment 3

[Wan-Teh Chang]

This bug was originally filed as Bugscape bug 57283.

Comment 4

[glen beasley]

Comment on attachment 166373 [details] [diff] [review]
Proposed patch

looks great. And the tip is open for checkins.

Comment 5

[Wan-Teh Chang]

I've checked in the patch on the JSS trunk
and JSS_3_X_BRANCH (JSS 3.5.1).

What's the JSS version on the JSS trunk?

Comment 6

[glen beasley]

The version on the tip is JSS 4.0.

The following binary compatibility issues were introduced from JSS 3.1 and JSS
3.5 (actually between JSS 3.1 and JSS 3.2)

org/mozilla/jss/ssl/SSLSocket.java

> public native void setCipherPreference(int cipher, boolean enable)
< public static native void setCipherPreference(int cipher, boolean enable);

> public native boolean getCipherPreference( int cipher)
< public static native boolean getCipherPreference( int cipher);

user's need to recompile since the since the "static" was removed from the set
and get methods. This was done in JSS 3.2.

Removal of org/mozilla/jss/provider/Provider.java which was changed to
org/mozilla/jss/JSSProvider.java. This was done in JSS 3.2. We cannot put a
pointer class by adding a new Provider.java that extends JSSProvider.java
because JSSProvider is defined as "public final class".

org/mozilla/jss/crypto/KeyWrapAlgorithm.java

>protected KeyWrapAlgorithm(int oidTag, String name, Class paramClasses, boolean
padded, int blockSize) {


All three problems break binary compatibility with jss 3.1.x branch.