270711 - "About Junk Mail" refers to nonexistent "Help" button

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[j.smith]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

When you go to the "Junk Mail Controls" in Thunderbird (Tools -> Junk Mail
Controls. . .) for the first time, a dialog box pops up to inform the user about
the controls.  On this dialog box (About Junk Mail), it has an "Ok" and a "Help"
button.  If you click on the "Help" button nothing happens.  Reproduced problem
on a second machine, but cannot reproduce problem again because the "About Junk
Mail" dialog does not show up again after clicking on "Tools -> Junk Mail
Controls..." (it just goes straight to the junk mail controls).

Reproducible: Always
Steps to Reproduce:
1.Open Thunderbird
2. On the toolbar, click on "Tools -> Junk Mail Controls..."
3.  If the "About Junk Mail" dialog appears, click on the "Help" button.
4. NOTE: If this is the first time running the junk mail controls, the "About
Junk Mail" dialog box (the one in question) will appear, but subsequent attempts
to access the junk mail controls form will not produce the "About Junk Mail"
dialog box.

Actual Results:  
Clicking on the "Help" button on the "About Junk Mail" dialog did not lauch any
help documentation or applications.

Expected Results:  
Launch help documenation/application/website relating to the junk mail controls.

Machine info:
Windows NT 5.1 SP1; .NET CLR 1.1.4322.573

Thunderbird info:
version 0.9 (20041103)

Comment 1

[Mike Cowperthwaite]

The help button has actually already been removed, as of 0.9+1112.  This was 
probably fixed by bug 256915's patch.

The text of the box, however, still reads "For more information, click Help."

Comment 2

[Scott MacGregor]

Attachment: the fix

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 166486 [details] [diff] [review]
the fix

a=asa for trunk checkin.

Comment 4

[trix supremo]

verified on 20041122 builds