270715 - storage should be pulled in default pull

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attached patch to client.mk adds mozilla/storage to default pull.  Discuss.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: storage-client-mk.patch

The client.mk patch. (Look ma, no SeaMonkeyAll!)

Comment 2

[Darin Fisher]

Comment on attachment 166394 [details] [diff] [review]
storage-client-mk.patch

hmm... i suspect that bsmedberg's reworking of client.mk will affect this.

see:
http://www.saintpatrickdc.org/bsmedberg/index.php?p=34

Comment 3

[Darin Fisher]

Comment on attachment 166394 [details] [diff] [review]
storage-client-mk.patch

This patch doesn't apply, and I think you should ask bsmedberg or bryner to
review the build changes.  Probably bsmedberg given his client.mk changes ;)

I'll post some review notes here on mozilla/storage.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: storage-client-mk.patch

Er, this got much easier with the new client.mk.. adding storage to
MODULES_suite.

Comment 5

[Benjamin Smedberg]

Comment on attachment 167515 [details] [diff] [review]
storage-client-mk.patch

r=me for the build-config change. Is there general agreement from drivers to
add this to the pull+build?

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #5)
> (From update of attachment 167515 [details] [diff] [review])
> r=me for the build-config change. Is there general agreement from drivers to
> add this to the pull+build?

There is agreement to add it to the pull; not yet to the build.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: addendum patch for storage pull, and build

This patch adds db/sqlite3 to the pull, and also adds both directories to the
build.	Note that this needs to be moved much earlier in the build once I
separate out the xpconnect dependency.

Comment 8

[Benjamin Smedberg]

Comment on attachment 168396 [details] [diff] [review]
addendum patch for storage pull, and build

r=me without the comment. This does not need to be in tier 1 for any reason I
can see, and the only possible dependency from tier 9 is RDF; let's cross that
bridge when we come to it.

Comment 9

[Brett Wilson]

I'm pretty sure storage is built automagically now by default for Fx2 and trunk.