270729 - XPCNativeWrapper doesn't exist on 1.4 branch security fix bustage

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[jon rekai]

The fix checked in to the 1.4 branch on 10/28 for bug 249332 is dependent upon
XPCNativeWrapper, which doesn't exist.

(At least middle click pasting of URLs into the content area and middle clicking
to open a link in a new tab is broken as a result.  Error message is displayed
in the JS console: XPCNativeWrapper is not defined ...)

Adding XPCNativeWrapper is minor.  Patch coming up.

Comment 1

[jon rekai]

Attachment: proposed fix

Add XPCNativeWrapper, and include it from files that include
contentAreaClick.js.

Comment 2

[[e-mail]]

Comment on attachment 166404 [details] [diff] [review]
proposed fix

That's odd - trunk gets away with including it in contentAreaContextOverlay.xul
which doesn't itself include contentAreaClick.js

Comment 3

[jon rekai]

(In reply to comment #2)

Including it from contentAreaContextOverlay.xul only seems fine for the browser
but XPCNativeWrapper isn't defined for messageWindow or p3pSummary.  (It seems 
this behavior exists in 1.7 and trunk, bug 267378, also a result of bug 249332.)

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 166404 [details] [diff] [review]
proposed fix

r/a=caillon for 1.4 only

Comment 5

[jag (Peter Annema)]

Comment on attachment 166404 [details] [diff] [review]
proposed fix

r=jag (or sr, up to Neil).

Comment 6

[[e-mail]]

Comment on attachment 166404 [details] [diff] [review]
proposed fix

Trunk seems to have the includes in different files but whatever works...

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[jon rekai]

v.

Thanks!