XPCNativeWrapper doesn't exist on 1.4 branch security fix bustage

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
14 years ago
14 years ago

People

(Reporter: jon, Assigned: jag-mozilla)

Tracking

({regression})

1.4 Branch
regression

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
The fix checked in to the 1.4 branch on 10/28 for bug 249332 is dependent upon
XPCNativeWrapper, which doesn't exist.

(At least middle click pasting of URLs into the content area and middle clicking
to open a link in a new tab is broken as a result.  Error message is displayed
in the JS console: XPCNativeWrapper is not defined ...)

Adding XPCNativeWrapper is minor.  Patch coming up.
(Reporter)

Comment 1

14 years ago
Created attachment 166404 [details] [diff] [review]
proposed fix

Add XPCNativeWrapper, and include it from files that include
contentAreaClick.js.
(Reporter)

Updated

14 years ago
Attachment #166404 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #166404 - Flags: review?(jag)

Updated

14 years ago
Severity: normal → major

Comment 2

14 years ago
Comment on attachment 166404 [details] [diff] [review]
proposed fix

That's odd - trunk gets away with including it in contentAreaContextOverlay.xul
which doesn't itself include contentAreaClick.js
(Reporter)

Comment 3

14 years ago
(In reply to comment #2)

Including it from contentAreaContextOverlay.xul only seems fine for the browser
but XPCNativeWrapper isn't defined for messageWindow or p3pSummary.  (It seems 
this behavior exists in 1.7 and trunk, bug 267378, also a result of bug 249332.)
Comment on attachment 166404 [details] [diff] [review]
proposed fix

r/a=caillon for 1.4 only
Attachment #166404 - Flags: review?(jag) → review+
(Assignee)

Comment 5

14 years ago
Comment on attachment 166404 [details] [diff] [review]
proposed fix

r=jag (or sr, up to Neil).
Product: Core → Mozilla Application Suite

Comment 6

14 years ago
Comment on attachment 166404 [details] [diff] [review]
proposed fix

Trunk seems to have the includes in different files but whatever works...
Attachment #166404 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Comment 7

14 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

14 years ago
v.

Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.