270787 - Toolbar elements not removed from menu bar (and stop working) when "Restore Default Set" is used in customize pane

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[David Morel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.5) Gecko/20041111 Firefox/1.0 (Debian package 1.0-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.5) Gecko/20041111 Firefox/1.0 (Debian package 1.0-2)

I use customized toolbars: I move the location and google find boxes to the very
top left, navigation icons to the developer bar, and hide the navigation bar
(see screenshot is at http://www.amakuru.net/capture4.png ). I had to reset the
toolbar to default as I couldn't remove a custom toolbar (bug already
referenced). My navigation toolbar stayed hidden but the top location box did
not disappeared. I tried to type stuff in it for a while, to n avail.

Reproducible: Always
Steps to Reproduce:
1.move the location and google find boxes to the top bar (menu bar)
2.hide Navigation bar
3.restore default toolbars (navigation toolbar stays hidden but new location and
find boxes are placed in it)
4.(after restarting i guess) type an address in the top location bar: fail!

Actual Results:  
Location bar doesn't work anymore

Expected Results:  
Removed the location box and others from menu bar

Comment 1

[PikeUK]

Confirmed, was just about to file a bug on this, ->OS:All, title changed to ease
searching.

Here's the report I was just about to submit:

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050630 Firefox/1.0+

Steps to reproduce
1. Create a new profile (not necessary but will ensure your layout is preserved).
2. Goto View->Toolbars->Customize.
3. Drag a button between the menubar and the flexible space in the top toolbar.
4. Click "Restore Default Set".

Expected results
Default button layout is restored.

Actual results
The newly added button is not removed.

Regression window:
Works - Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Fails - Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20041026
Firefox/1.0RC1

For bonus points restart Firefox then click "Restore Default Set" again, notice
how Fx adds a flexible space each time you repeat this process.

This seems to be caused by firstPermanentChild and lastPermanentChild in
toolbar.xml. The currentSet setter removes all icons except items between
firstPermanentChild and lastPermanentChild then it adds the icons from the new
set. The top toolbar has a firstPermanentChild equal to the menubar and a
lastPermanentChild equal to the update icon, anything between them will not be
removed when restoring the default set.

Comment 2

[PikeUK]

*** Bug 282831 has been marked as a duplicate of this bug. ***

Comment 3

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 300567 has been marked as a duplicate of this bug. ***

Comment 4

[PikeUK]

Ben removed the update button yesterday which has fixed this problem (or the
symptoms at least, the toolbar binding is still prone to breakage if a second
permanent toolbar item is re-added in the future).

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 315160 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Connor [:mconnor]]

Marking WFM