270797 - ###!!! ASSERTION: null data pointer: 'Not Reached', file r:\mozilla\xpcom\string\src\nsTSubstring.cpp, line 599

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[timeless]

###!!! ASSERTION: null data pointer: 'Not Reached', file
r:\mozilla\xpcom\string\src\nsTSubstring.cpp, line 599
Break: at file r:\mozilla\xpcom\string\src\nsTSubstring.cpp, line 599
 	xpcom_core.dll!nsDebug::Assertion(const char * aStr=0x00396688, const char *
aExpr=0x00388f84, const char * aFile=0x0039669c, int aLine=0x00000257)  Line 109	C++
>	xpcom_core.dll!nsCSubstring::Equals(const char * data=0x00000000)  Line 600	C++
 	msgbase.dll!nsMsgAccountManager::InternalFindServer(const char *
username=0x015f6088, const char * hostname=0x00000000, const char *
type=0x015f5eb0, int useRealSetting=0x00000000, nsIMsgIncomingServer * *
aResult=0x0012d864)  Line 1906 + 0x1b	C++
 	msgbase.dll!nsMsgAccountManager::FindServer(const char * username=0x015f6088,
const char * hostname=0x00000000, const char * type=0x015f5eb0,
nsIMsgIncomingServer * * aResult=0x0012d864)  Line 1950	C++
 	msgbase.dll!nsMsgAccountManager::GetLocalFoldersServer(nsIMsgIncomingServer *
* aServer=0x0012d864)  Line 2421	C++
 	xpcom_core.dll!XPTC_InvokeByIndex(nsISupports * that=0x03062f58, unsigned int
methodIndex=0x0000001d, unsigned int paramCount=0x00000001, nsXPTCVariant *
params=0x0012d864)  Line 102	C++

nsMsgAccountManager::GetLocalFoldersServer
      rv = FindServer("nobody",nsnull,"none",aServer);

this code has been this way since the beginning of time, but someone should fix it

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

timeless, mcsmurf says you're working on this.  I think it's sufficient to add
hostname && username && type
to the front of the "if" at
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgAccountManager.cpp#1907

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

These were the only broken callers i found.

Comment 3

[[e-mail]]

Comment on attachment 166461 [details] [diff] [review]
Patch

OK, so when reviewing the original code I didn't spot that Equals isn't allowed
null pointers so it's InternalFindServer that needs to be fixed.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

Comment 5

[[e-mail]]

Comment on attachment 166577 [details] [diff] [review]
Patch 2

Although you didn't need to move useRealSetting...

Comment 6

[timeless]

Comment on attachment 166577 [details] [diff] [review]
Patch 2

mozilla/mailnews/base/src/nsMsgAccountManager.cpp	1.298