270823 - Time since owner touched search fails

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Jon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

When using the advance searching with boolean charts and searching on "Time
since owner touched" it reports back with the error message below.  This happens
the tip.  It seems to work on the 2.18 branch (it produces a buglist instead of
an error for that code).

Software error:

DBD::mysql::st execute failed: You have an error in your SQL syntax near 'ON ()
AND () LEFT JOIN bug_group_map  ON bug_group_map.bug_id = bugs.bug_id  AND' at
line 1 [for Statement "SELECT bugs.bug_id, bugs.bug_severity, bugs.priority,
bugs.bug_status, bugs.resolution, bugs.bug_severity, bugs.priority,
bugs.rep_platform, map_assigned_to.login_name, bugs.bug_status, bugs.resolution,
bugs.short_desc FROM bugs, profiles AS map_assigned_to  LEFT ON () AND () LEFT
JOIN bug_group_map  ON bug_group_map.bug_id = bugs.bug_id  AND
bug_group_map.group_id NOT IN (6,7)  LEFT JOIN cc ON cc.bug_id = bugs.bug_id AND
cc.who = 3494 WHERE bugs.assigned_to = map_assigned_to.userid AND
(comment_idle_0.who IS NULL AND activity_idle_0.who IS NULL) AND ((0=0)) AND
((bug_group_map.group_id IS NULL)    OR (bugs.reporter_accessible = 1 AND
bugs.reporter = 3494)     OR (bugs.cclist_accessible = 1 AND cc.who IS NOT NULL)
    OR (bugs.assigned_to = 3494) ) GROUP BY bugs.bug_id ORDER BY
bugs.bug_status,bugs.priority,map_assigned_to.login_name,bugs.bug_id "] at
Bugzilla/DB.pm line 62
	Bugzilla::DB::SendSQL('SELECT bugs.bug_id, bugs.bug_severity, bugs.priority,
bugs.bu...') called at /var/www/html/bugzilla-tip/buglist.cgi line 762


Reproducible: Always
Steps to Reproduce:

Comment 1

[Joel Peshkin]

Bleah....

This is more likely to effect more than just that one query.  Probably any
relatively fancy boolean chart would do the same.  I'll try to repro this this
weekend.

Comment 2

[Dave Miller [:justdave]]

yeah, this is an advertised new feature, we probably better make sure it works
right. :)

Comment 3

[Joel Peshkin]

Attachment: Patch - removes linebreak from middle of join clause

The linebreak in the middle of the ownew_idle criteria was confusing the code
that consolidates the join conditions.

Comment 4

[Jon]

Making the same change as in the patch to my copy makes it work for me.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 166624 [details] [diff] [review]
Patch - removes linebreak from middle of join clause

works for me

Comment 6

[Vlad Dascalu]

Justdave said I can commit this one. Thanks Joel!

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.70; previous revision: 1.69
done