270909 - bonsai broken with perl 5.8.5

Status: VERIFIED INVALID

(Webtools Graveyard :: Bonsai, defect)

Description

[cls]

IT upgraded the hardware on the CVS server a couple of weeks ago and in the
process, they upgraded perl to 5.8.5.  Now, I've noticed that CVS diffs seem to
be broken.  When viewing the diffs, it only shows the lines that have been
added, not the lines that have been removed or the content that was not touched.

Looking at the new warnings that are showing up in the apache log, certain perl
constructs are not returning the same values as before.  For example, in
cvsview2.cgi,
   my $opt_whitespace_mode   = $request->param('whitespace_mode') || 'show';
no longer returns 'show' if 'whitespace_mode' wasn't given as a parameter. 
However if I add,
    $opt_whitespace_mode = 'show' if !defined($opt_whitespace_mode);
after that line, then it gets set.

Comment 1

[cls]

This is collective operator error.  IT moved the location of the 'co' binary and
cvsview2.cgi silently proceeded without valid data.

They were probably playing with perl too as I can't reproduce the ->param() issue.