270988 - Menubar higlighting on Linux not centered

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jaap A. Haitsma]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041119 Firefox/1.0 (Debian package 1.0-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041119 Firefox/1.0 (Debian package 1.0-3)

If you select an item in the menu bar on Linux the highlighting is not centered.
See the attachment. The patch correct this problem

Reproducible: Always
Steps to Reproduce:

Comment 1

[Jaap A. Haitsma]

Attachment: The way it looks now

Comment 2

[Jaap A. Haitsma]

Attachment: The way it looks after the patch

Comment 3

[Jaap A. Haitsma]

Attachment: The patch. BTW I picked up this change from Garrett LeSage's Industrial Firefox theme

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 166594 [details] [diff] [review]
The patch. BTW I picked up this change from Garrett LeSage's Industrial Firefox theme

Kevin, this would be a good little tweak for GNOME :)

Comment 5

[Kevin Gerich]

 menubar > menu {
-  padding: 0px 6px 0px 4px;
+  padding: 0px 3px 0px 5px;
 }

I'd prefer padding: 0 5px; just to make it even unless there's some other rule
pushing the padding out.

Comment 6

[Jaap A. Haitsma]

(In reply to comment #5)
>  menubar > menu {
> -  padding: 0px 6px 0px 4px;
> +  padding: 0px 3px 0px 5px;
>  }
> 
> I'd prefer padding: 0 5px; just to make it even unless there's some other rule
> pushing the padding out.
If you do that the items in the menubar will be to far apart. My suggestion of
padding: 0px 3px 0px 5px; seems to give the best result. The menu looks
identical to for example the menu of a native gnome app such as app.
I also tried padding: 0px 4px 0px 4px but then the spacing between items is too
small.

Comment 7

[Kevin Gerich]

Here's what I checked in

===================================================================
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu.css,v
retrieving revision 1.7
diff -u -r1.7 menu.css
--- themes/gnomestripe/global/menu.css  18 Feb 2005 06:03:08 -0000      1.7
+++ themes/gnomestripe/global/menu.css  9 Mar 2005 21:38:58 -0000
@@ -70,7 +70,7 @@
 }

 menubar > menu {
-  padding: 0px 6px 0px 4px;
+  padding: 0px 4px;
 }

 menubar > menu[_moz-menuactive="true"] {
@@ -141,7 +141,7 @@
 }

 .menubar-text {
-  margin: 0px 2px 0px 0px !important;
+  margin: 0 1px !important;
   color: inherit;
 }