271032 - [Approval Queue] Replace "No Action" with Cancel button

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, enhancement)

Description

[alanjstr]

To protect author privacy from regular "approvers", I don't think that the
author name should have the email address.  If the "approver" wants to send a
message, they should use the "No Action" radio button.

Comment 1

[Wolf [:wolf]]

No. The No Action button does just that. Ignores the record as it runs the
processing upon a submit action. If there's a question then it needs to be
handled quickly, there's no harm in allowing staff to view that address, because
the same people who have access to that form have access to the user manager.

--> wontfix.

Comment 2

[alanjstr]

Oh.  Then we need a Cancel button.

It is confusing to have to select that radio button and then click Submit, since
you're not really Submitting data.  The "no action" radio button would then let
us contact the author.  Maybe rename it to "Contact author"

Comment 3

[Wolf [:wolf]]

It's a tri-action system. If no-action is selected (which is default) then it's
ignored. It does not attempt to do anything, definitely not send e-mail,
renaming it to "Contact Author" would be entirely wrong, as it doesn't do that.
You wouldn't want to contact everybody waiting every time you approve some items.

You only modify records that you're taking an action on.

Comment 4

[alanjstr]

I understand your "tri-action" idea, I just think that the "No action" item is
weird and would be better as a "Cancel" button.  However, I can see a need for
the email address, like if you want to request more info.

Comment 5

[Wolf [:wolf]]

I disagree, as Cancel doesn't describe the action being taken. You're taking no
action on that record. as opposed to Approving or Denying it. A Cancel button
would not function in a multiple-items at once enviroment. You're not cancelling
something you haven't done.

Comment 6

[alanjstr]

You're cancelling your decision to do something.  Like if you click on it to
test it, and then change your mind.  Many web forms use it for exactly that
purpose.  I think it is much better than a Reset button on that screen.  

Or are you saying that you would want to save some information, but neither
Approve or Deny it?

Comment 7

[Wolf [:wolf]]

No Action takes just that, No action. It skips the record when processing the
form changes.
You're confusing Reset and No Action, reset clears your form changes, just as
you'd expect.

Comment 8

[alanjstr]

Reopening to fix the status.  I disagree, but I'm not going to push the issue.