271068 - Frozen PSM headers are not part of the gecko sdk

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

several psm headers are frozen, but not in the sdk:
chb@linux:~/mozilla/security/manager> find -name *.idl|xargs grep FROZEN
./ssl/public/nsIX509CertDB.idl: * @status FROZEN
./ssl/public/nsICRLInfo.idl: * @status FROZEN
./ssl/public/nsIASN1Object.idl: * @status FROZEN
./ssl/public/nsICertificateDialogs.idl: * @status FROZEN
./ssl/public/nsIX509Cert.idl: * @status FROZEN
./ssl/public/nsIASN1Sequence.idl: * @status FROZEN
./ssl/public/nsIX509CertValidity.idl: * @status FROZEN
./ssl/public/nsIBadCertListener.idl: * @status FROZEN
./boot/public/nsISecurityWarningDialogs.idl: * @status FROZEN

the makefiles should use SDK_XPIDLSRCS for them...

Unless optionally built components should not be part of the SDK?

Comment 1

[Darin Fisher]

I think it's fine to include optional interfaces in the Gecko SDK.  Afterall,
XPCOM is very supportive of optionally available components at runtime :-)

I wonder if the same can be said of the OJI interfaces?

Comment 2

[Crispin Flowerday (not receiving bug mail)]

Attachment: Install frozen headers in sdk

Comment 3

[Benjamin Smedberg]

Comment on attachment 168053 [details] [diff] [review]
Install frozen headers in sdk

Looks great.

Comment 4

[Darin Fisher]

Comment on attachment 168053 [details] [diff] [review]
Install frozen headers in sdk

sr=darin (thanks for doing this!)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk for 1.8alpha6.

Checking in security/manager/boot/public/Makefile.in;
/cvsroot/mozilla/security/manager/boot/public/Makefile.in,v  <--  Makefile.in
new revision: 1.3; previous revision: 1.2
done
Checking in security/manager/ssl/public/Makefile.in;
/cvsroot/mozilla/security/manager/ssl/public/Makefile.in,v  <--  Makefile.in
new revision: 1.22; previous revision: 1.21
done

Comment 6

[Crispin Flowerday (not receiving bug mail)]

Comment on attachment 168053 [details] [diff] [review]
Install frozen headers in sdk

Requesting approval for 1.7.5, this is a simple makefile change to get the
already frozen psm headers into the sdk.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 168053 [details] [diff] [review]
Install frozen headers in sdk

a=mkaply for 1.7.

Please checkin quick.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, checked it into the 1.7 branch

Checking in security/manager/boot/public/Makefile.in;
/cvsroot/mozilla/security/manager/boot/public/Makefile.in,v  <--  Makefile.in
new revision: 1.2.50.1; previous revision: 1.2
done
Checking in security/manager/ssl/public/Makefile.in;
/cvsroot/mozilla/security/manager/ssl/public/Makefile.in,v  <--  Makefile.in
new revision: 1.20.2.1; previous revision: 1.20
done