271079 - [Submission] Uploading Legacy first does not store GUID for non-legacy uploads

Status: VERIFIED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

This was discovered from BiDi Mail UI, which has now been corrected.

When a legacy item is uploaded, such as an extension for Mozilla 1.x, it has no
GUID.  If someone then goes to upload a non-legacy version, ie TB, the GUID is
not stored since UMO thinks it is just a new version.

Bug 258995 is related and may exascerbate the problem.  
But 246891 is a possible solution.

Comment 1

[Wolf [:wolf]]

Yeah, I was aware this existed. It's part of how new/updated code works, if it's
an update it doesn't verify/update the main record intentionally, IIRC.

In theory, the fix for Bug 258995 should reject the mismatch here too, but it
may not. Has this been tested on update-beta? or only on update?

Comment 2

[alanjstr]

I haven't tested it in Beta.  You've changed the code around so I don't know
what it would do.  Any chance that the code has some documentation at the top
that demonstrates the decision tree?

Comment 3

[Wolf [:wolf]]

This is Mozilla, you know better than to expect documentation :-P

Comment 4

[Wolf [:wolf]]

Bulk Moving Developer Control Panel bugs to new component.
(Filter: massdevcpspam)

Comment 5

[Mike Shaver (:shaver emeritus)]

No more legacy uploads, ever.