Closed
Bug 271142
Opened 20 years ago
Closed 20 years ago
Remove all files in parser/htmlparser/tools from CVS since they are obsolete (genentities.pl, gentags.pl)
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
VERIFIED
FIXED
People
(Reporter: engel, Assigned: engel)
References
Details
Attachments
(1 file)
239 bytes,
text/plain
|
mrbkap
:
review+
dbaron
:
superreview+
|
Details |
The perl scripts http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/parser/htmlparser/tools/genentities.pl&rev=1.5&root=/cvsroot and http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/parser/htmlparser/tools/gentags.pl&rev=1.15&root=/cvsroot are no longer in use and should be removed from the tree. Historically, these script were used to generate code containing a list of HTML-entities or HTML-tags, resp. However, the output code of these scripts is quite obsolete and these scripts have not been used in a long time. Indeed, looking at Rev 3.1 of http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/parser/htmlparser/src/nsHTMLEntityList.h#3.1 , we find that the perl code generation has been replaced. 3.1 <peterl@netscape.com> 1999-07-17 17:12 changed to preprocessor for code generation for tag & entity tables cleanup tag and entity lookup apis Note that the entities are currently defined in http://lxr.mozilla.org/seamonkey/source/parser/htmlparser/src/nsHTMLEntityList.h http://lxr.mozilla.org/seamonkey/source/intl/unicharutil/tables/ http://lxr.mozilla.org/seamonkey/source/content/xml/content/src/xhtml11.dtd http://lxr.mozilla.org/seamonkey/source/layout/mathml/content/src/mathml.dtd http://lxr.mozilla.org/seamonkey/source/parser/htmlparser/tests/html/entity_attrlist.html http://lxr.mozilla.org/seamonkey/source/parser/htmlparser/tests/html/entity_list.html . The tags are defined in http://lxr.mozilla.org/seamonkey/source/parser/htmlparser/public/nsHTMLTagList.h which then generates "eHTMLTag_" in combination with http://lxr.mozilla.org/seamonkey/source/parser/htmlparser/public/nsHTMLTags.h#45 .
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #166711 -
Flags: review?(mrbkap)
Comment 2•20 years ago
|
||
Comment on attachment 166711 [details]
Placeholder to request r/sr for file removal
Good catch.
r=mrbkap
Attachment #166711 -
Flags: review?(mrbkap) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #166711 -
Flags: superreview?(dbaron)
Attachment #166711 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 3•20 years ago
|
||
Thank you for the lightning fast reviewing and super-reviewing. Less than an hour each, I am impressed!
Updated•20 years ago
|
Assignee: parser → Hans-A.Engel
Comment 4•20 years ago
|
||
Checked in. Removing tools/genentities.pl; /cvsroot/mozilla/parser/htmlparser/tools/genentities.pl,v <-- genentities.pl new revision: delete; previous revision: 1.5 done Removing tools/gentags.pl; /cvsroot/mozilla/parser/htmlparser/tools/gentags.pl,v <-- gentags.pl new revision: delete; previous revision: 1.15 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•