271143 - Java SDK doesn't compile on Java 1.5

Status: RESOLVED FIXED

(Directory :: LDAP Java SDK, defect)

Description

[R.J. Keller]

There are some reserved words in Java 1.5 that are used as variable names in the
Directory SDK. This needs to be fixed or else it won't build on Java 1.5.

Attaching patch...

Comment 1

[R.J. Keller]

Attachment: Patch - vars can't use reserved words

Comment 2

[Mark Smith [:mcs]]

Comment on attachment 166712 [details] [diff] [review]
Patch - vars can't use reserved words

Looks fine to me.  I also added EY to the CC so he can take a look.

Comment 3

[R.J. Keller]

What's the policy for checkin to directory?

Comment 4

[Mark Smith [:mcs]]

For the LDAP JDK code, I think it is OK to commit with one review and a sanity
check by a module owner.  E-Y, is the LDAP JDK currently bundled with any
Mozilla product?

Comment 5

[R.J. Keller]

(In reply to comment #4)
> For the LDAP JDK code, I think it is OK to commit with one review and a sanity
> check by a module owner.  E-Y, is the LDAP JDK currently bundled with any
> Mozilla product?

I know that C++ Directory is shipped with Mozilla. I would really doubt Java SDK
would be shipped with any Mozilla products but I could be wrong. I actually made
this patch when attempting to get Grendel working with Java 1.5.

Obviously I tested this patch with Java 1.5. I couldn't think of it breaking any
other version of Java.

Comment 6

[Erhyuan Tsai]

This change looks good.

Comment 7

[R.J. Keller]

Can one of you guys check this in for me? I lost my CVS SSH key and am still
waiting for them to register my new key (it's been a month :(, hopefully someone
will find me). I also couldn't find nobody on IRC to check this in for me.

Comment 8

[R.J. Keller]

Fix checked in. Got CVS working.