271164 - "Open with" disabled for root

Status: RESOLVED EXPIRED

(Toolkit :: Downloads API, defect)

Description

[flobber]

User-Agent:       Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.7.5) Gecko/20041120 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.7.5) Gecko/20041120 Firefox/1.0

When activating a link with an unknown mime-type
handler the Opening dialog pops up.  When running
under root, the only available option is "Save to
Disk".  The "Open with" option is disabled.

I tracked it down to the "don't open binary checks"
in nsHelperAppDlg.js in particular the isExecutable
checks.  This method is based on access(2) which,
according to posix (and my system *g*), returns X_OK
for every file when called by root.  I don't think
this check makes much sense under Unix systems, espe-
cially as nobody sets the x-bit for those temp-files.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch that works perfectly

no pixel artifacts here!

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 166890 [details] [diff] [review]
patch that works perfectly

bah. wrong bug. nevermind!

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.