271220 - Updating a theme can keep multiple versions of the theme ".jar" file in its directory

Status: RESOLVED DUPLICATE of bug 251026

(Toolkit :: Add-ons Manager, defect)

Description

[Rastignac]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Sometimes Firefox keeps two (or more) versions of the ".jar" files in the same
directory when you update a theme.

Reproducible: Sometimes
Steps to Reproduce:
- You have a theme already installed in Firefox.
- You download a new version (".jar") of this theme from the Net.
- You drag'n'drop this ".jar" file onto the theme manager.
- Then the theme is updated with its newer version.
- You close the theme manager and FireFox.
- Now you look in your "profiles / extensions" subdirectories.
- Sometimes, the theme can have two ".jar" files in its directory ! FireFox
didn't delete the old ".jar". It keeps the old one and the new one.
Actual Results:  
Sometimes, the old ".jar" file is not deleted. So there are two (or more) ".jar"
files in the same directory (the old and the new version of the theme).

Expected Results:  
Only one ".jar" should be kept for each theme.

After a few theme updates, your profile will contain a lot of obsolete and
unused big files !

This bug does not always appear. Some updated themes are OK, some updated themes
are KO. I can't find why (random ?), but it happens for about 30% of my
installed themes. They are all installed the same way, so there's no differences
to explain why it failed. A problem with the theme itself ?

I now have in my profile subdirectories:
- MozillaFirefox_littlefox_10.jar (156 266 bytes) and
MozillaFirefox_littlefox_101.jar (154 982 bytes) in the same directory.
- archaic.0.1.0.jar (277 494 bytes) and MozillaFirefox_archaic_0_3_0.jar (305
802 bytes) in the same directory.
- MozillaFirefox_pinball-fx_0.9.9.1.jar (373 007 bytes) and
MozillaFirefox_pinball-fx_0.9.9.2.jar (373 016 bytes) in the same directory.
- 708090-lite_1.47.jar (129 353 bytes) and 
MozillaFirefox_708090-lite_1.49.jar (126 764 bytes) in the same directory.
- MozillaFirefox_graymodern0.6.1.jar (428 648 bytes) and
MozillaFirefox_graymodern0.6.2.jar (428 785 bytes) in the same directory.

But some other themes, updated with exactly the same procedure, are fine...

Comment 1

[Nickolay_Ponomarev]

*** This bug has been marked as a duplicate of 264088 ***

Comment 2

[Rastignac]

This is NOT a duplicate !

- The other bug (bug #264088) is about themes that appear twice in the UI.
- This bug is about themes that appear once in the UI but that have multiple
files in their directory.

That's not the same thing. The problem is not the same.

I reopen this bug. This bug is not a duplicate at all.

Comment 3

[Nickolay_Ponomarev]

at least it depends on bug 264088 and bug 251026.

Comment 4

[Rastignac]

Please, reopen this bug.
This bug is NOT a duplicate.
This bug is not invalid and is still present.
This bug can be reproduced.
This bug is not fixed.
Thanks.

Comment 5

[Nickolay_Ponomarev]

This bug is unconfirmed. It don't need (cannot) be reopened, only resolved bugs
can be reopened. It's not confirmed yet because it's hard to reproduce a bug
which is reproducible in 30% even for you.

Comment 6

[Robert Strong (they/them - no direct email)]

This bug has been fixed by the patches for bug 286034 and bug 291946. Resolving
this bug as a duplicate of bug 251026 since they describe the exact same issue.

*** This bug has been marked as a duplicate of 251026 ***

Comment 7

[Rastignac]

This bug is not solved at all !! Then, I must reopen this bug.

I've just looked in my profile directory and, shocking!!, this bug is still
present. It has been present for monthes and is still here. (My FireFox is
upgraded every time).

I have a hell a lot of files in each of my themes' directory !

The ColorGnome directory contains:
13/06/2005  12:00           675 045 colorgnome-0.3-fx.jar
15/06/2005  17:14           685 511 colorgnome-0.4-fx.jar
23/06/2005  15:00           678 199 colorgnome-0.5-fx.jar
27/06/2005  15:22           850 842 colorgnome-0.6-fx.jar
30/06/2005  16:09           892 251 colorgnome-0.7-fx.jar
06/07/2005  16:29           916 229 colorgnome-0.9.2-fx.jar
11/07/2005  10:32         1 004 288 colorgnome-0.9.3-fx.jar
02/09/2005  15:31         1 087 639 colorgnome-1.1.5-fx.jar
08/09/2005  14:26         1 086 390 colorgnome-1.1.6-fx.jar
19/09/2005  15:58         1 088 436 colorgnome-1.1.7-fx.jar

The WhiteHart directory contains:
29/04/2005  16:39           218 045 whitehart-0.0.8-fx.jar
23/05/2005  13:51           258 947 whitehart-0.1.4-fx.jar
17/05/2005  15:57           213 542 Whitehart_0.1.2.jar
17/05/2005  16:05           255 847 Whitehart_0.1.3.jar
29/04/2005  16:51           195 100 Whitehart_010.jar

Etc. Etc.

The same bug exists for every theme in my profile ! That's a very big number of
obsolete files, taking a very big total size on my harddisk...

Thanks.

Comment 8

[Nickolay_Ponomarev]

What Firefox version is that? The bug was fixed in Firefox 1.5beta, and even
there I don't think Firefox will delete the files left from an older version.

Comment 9

[Robert Strong (they/them - no direct email)]

It is fixed on the MOZILLA_1_8_BRANCH which will become Firefox 1.5 and on the
current trunk.

Comment 10

[Robert Strong (they/them - no direct email)]

Rastignac - when a release is made typically only security fixes are made to the
release. So, 1.0 was released and there have been 7 minor releases so far to 1.0
which brings us to 1.0.7. Fixes for bugs like this one will for all practical
purposes never be made to the 1.0 release... instead they are made to the code
that will become the next release which in this case is 1.5. This is fixed and
if you'd like to verify this you can do so using the beta release or wait until
1.5 is released.

Comment 11

[Robert Strong (they/them - no direct email)]

*** This bug has been marked as a duplicate of 251026 ***