271223 - Uninstalling active theme and selecting use theme for another theme activates the default theme

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[alanjstr]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041109 Firefox/1.0 (MOOX M3)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041109 Firefox/1.0 (MOOX M3)

If I uninstall the theme I'm currently using and select a different theme before
I restart, I still get the default theme as my active theme.

Reproducible: Always
Steps to Reproduce:
1.  Install Pinball and Walnut themes from UMO
2.  Set Walnut as your active theme and restart
3.  Uninstall Walnut and set Pinball as active
4.  Restart

Actual Results:  
Default theme is used

Expected Results:  
Pinball theme is used

Comment 1

[alanjstr]

Uninstalling a theme unselects whatever you selected to be the active theme.  If
I again pick the new theme and click Use Theme, the new theme is used next time.

Comment 2

[Robert Strong (they/them - no direct email)]

*** Bug 278089 has been marked as a duplicate of this bug. ***

Comment 3

[Shriramana Sharma]

Just noting that this bug happens even when a new theme is selected for use *before* the active theme is selected for uninstall.

Comment 5

[Alfred Kayser]

When the current active theme is uninstalled, FF (and TB and ...) try to switch from that to the default theme. This change is then kept until the restart to apply this change. 

When the theme that is to be uninstalled is not active, the uninstall can fail if the current theme doesn't skin all components that the theme that is being installed skins. (because there are still references to the 'old' theme for those components) (so if Walnut also skins 'downloadmgr' but 'Pinball' not, when Pinball is active, uninstalling Walnut (if it was active before pinball) will not work...

First selecting the default skin, restarting, and do the operation you want is a safer way.

Comment 6

[alanjstr]

Couldn't those missing references be changed to the default theme automatically? 

Comment 7

[Robert Strong (they/them - no direct email)]

If that is a bug it would be a bug in our chrome reg code and not the EM

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to comment #7)
> If that is a bug it would be a bug in our chrome reg code and not the EM
In relation to the reference and not the uninstall failure that is

Comment 9

[Alfred Kayser]

The issue is happening when you switch from a author-theme with more components to another theme, then for components not supported by the new theme, it still uses the previous theme. It would be more logical to when that happens for compoenents linked to the old theme, when they are not covered in the new theme to link them back to the default theme (as the new theme will be probably assume that for components not supported, the default theme is used).

So, this is probably related to the chrome reg code.

However, the uninstall failure should report at least why it is failing to remove the theme.

Comment 10

[Dave Townsend [:mossop]]

I think this might be fixed

Comment 11

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre ID:20090422042031

This WFM

Comment 12

[Dave Townsend [:mossop]]

Per comment 11, I think this was fixed by some of the theme selection changes in Firefox 3.0