Closed Bug 271228 Opened 20 years ago Closed 20 years ago

On GTK2, first press of modifier + key sends KEY_PRESS event but no KEY_DOWN

Categories

(Core Graveyard :: GFX: Gtk, defect)

Product:
Core Graveyard
Component:
GFX: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

References

(
URL
)

Details

Attachments

(1 file)

Patch
1.16 KB, patch
aaronlev
: review+
neil
: superreview+
Details | Diff | Splinter Review 
In the attached URL, hold down a modifier key and press a normal key twice (e.g.
ALT-A-A, SHIFT-2-3, etc.).

The first key press sends a KEY_PRESS event but no KEY_DOWN. Subsequent presses
(without releasing the modifier key) send both events.
Attached patch Patch — — Splinter Review 
Assignee: blizzard → smontagu
Status: NEW → ASSIGNED

    
  

        Attachment #166771 -
        Flags: superreview?(jst)

        Attachment #166771 -
        Flags: review?(bryner)

    
    

    
  
Comment on attachment 166771 [details] [diff] [review]
Patch

Moving review request

        Attachment #166771 -
        Flags: review?(bryner) → review?(blizzard)

    
    

    
  
Comment on attachment 166771 [details] [diff] [review]
Patch

Switching review requestee again.

        Attachment #166771 -
        Flags: review?(blizzard) → review?(aaronleventhal)

    
  

        Attachment #166771 -
        Flags: review?(aaronleventhal) → review+

    
  

        Attachment #166771 -
        Flags: superreview?(jst) → superreview?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 166771 [details] [diff] [review]
Patch

sr=me assuming this gets commented and has been tested and doesn't make
modifier key events repeat!

        Attachment #166771 -
        Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

    
    

    
  
Yes to all of the above. Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: