271245 - Compile time problem in nsDerivedSafe/"nsCOMPtr.h"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[FFoxGuy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

You need to change the declaration of AddRef and Release methods in the
"nsDerivedSafe<T>" class in "nsCOMPtr.h"

Current declaration:
nsrefcnt AddRef(void);
nsrefcnt Release(void);

Correct declaration:
NS_IMETHOD_(nsrefcnt) AddRef(void);
NS_IMETHOD_(nsrefcnt) Release(void);

Reason: overriden virtual functions must have the same calling
convention as the virtual functions in the base class.

For example, the current code defaults to __fastcall calling convention for
nsDerivedSafe<T>::AddRef and nsDerivedSafe<T>::Release in Borland C++ Builder,
which results in a error because the same virtual function has different calling
conventions in a base and derived class.

Similar change is necessary for implementation of the methods



Reproducible: Always
Steps to Reproduce:
1. Try to build the XPCOM Glue library using Borland C++ Builder v6.0
2.
3.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This seems reasonable, since they're already (implicitly) virtual, so the only
thing this should change is the calling convention.

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Serge Gautherie (:sgautherie)]

(Assuming) Fixed by bug 279210, which removed this code.