Closed Bug 271315 Opened 20 years ago Closed 18 years ago

tbird on mac should use command-n as new message shortcut

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird2.0

People

(Reporter: mitch, Assigned: mscott)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/125.5.5 (KHTML, like Gecko) Safari/125.11
Build Identifier: version 0.9 (20041103)

Apple Mail uses command-n to open a new compose window, which seems more natural than 
command-shift-m.  Currently, command-n is not assigned in Thunderbird, and it seems to make sense 
to transition to this shortcut to make it easier for Mail users to convert.

Reproducible: Always
Steps to Reproduce:
1. Open Thunderbird
2. Hit Command-N On The Keyboard
Actual Results:  
Nothing Happens.

Expected Results:  
Thunderbird should open a new compose window.
The current shortcut is a legacy from the suite, where command-n was used for
something else. You might even want to assign two shortcuts to the same?
taking
Assignee: mscott → joshmoz
I'm not going to get to this, so back to mscott.

I think this should be a blocker since it is a big UI problem on the Mac and it
shouldn't be hard to fix.

Command-N is the standard new message command on Mac OS X, and it is also
standard for creating new documents in document editing Mac OS X applications.
New users are likely to be very turned off when Command-N doesn't work. Doesn't
matter if both keyboard shortcuts, Command-N and the current one work, but
Command-N needs to be the default, showing in the menu.
Assignee: joshmoz → mscott
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.8b4?
Is it ok to say ditto? Command-N would be great.
Flags: blocking1.8b4?
Keywords: helpwanted
*** Bug 322486 has been marked as a duplicate of this bug. ***
It would be worth considering this cross-platform. The shortcut is Ctrl+M on Windows, when Ctrl+N would be more appropriate. (Of course, Ctrl+M is a leftover from the Seamonkey all-in-one days.)
at least on windows, ctrl-m and ctrl-n both open a new compose window. Is that not the case for 1.5.0.2 on mac?
Target Milestone: --- → Thunderbird2.0
(In reply to comment #7)
> at least on windows, ctrl-m and ctrl-n both open a new compose window. Is that
> not the case for 1.5.0.2 on mac?

Nope. Only Command+Shift+M does New Compose Window. (Command+M is reserved for the OS Minimize-to-Dock command.)

On Windows, I do see that both work; however, Ctrl+M is what's shown in the menu. Maybe TB should show Ctrl+N for consistencys sake, though.
Attached patch the fixSplinter Review
1) Make Ctrl-N the default key we show in the File Menu for the 3-pane and the compose window for opening a new compose window. Ctrl-M still works as before, but ctrl-N is what we show in the UI.

2) In the address book ctrl-N opens a new address book card. We show Ctrl-M in the AB UI for opening a new compose window.

3) On the mac, use command-N instead of command-shift-N and show that in the UI for compose and the 3-pane. Same renaming rules listed in (1) and (2) apply. Command-shift-M still opens a compose window, but is not shown in the UI.
Comment on attachment 231813 [details] [diff] [review]
the fix

Fixing it this way instead of changing the actual values of newMessageCmd.key and newMessageCmd2.key, means the localizations won't have to be updated for this to just work.
Attachment #231813 - Flags: superreview?(bienvenu)
Attachment #231813 - Flags: review?(joshmoz)
Attachment #231813 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 231813 [details] [diff] [review]
the fix

great!
Attachment #231813 - Flags: review?(joshmoz) → review+
Attachment #231813 - Flags: approval-thunderbird2+
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: helpwantedfixed1.8.1
Resolution: --- → FIXED
OS: Mac OS X 10.2 → All
Hardware: Macintosh → All
You need to log in before you can comment on or make changes to this bug.