271343 - HashTable RemoveEntry should return boolean indicating whether it deleted sth or not

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Right now, RemoveEntry returns void, giving no indication whether the delete
succeeded or not.  Would be convenient to callers if it returned a boolean
indicating what happened.

Comment 1

[Darin Fisher]

nsHashPropertyBag would benefit from this.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Not sure if this has changed since the bug was filed, but PLDHashtable::RemoveEntry and nsTHashtable::RemoveEntry accept a pointer to an entry. This is obtained using PLDHashtable::Search resp. nsTHashtable::GetEntry. If there's no entry for a key, these functions return nullptr, and it's not valid to pass nullptr to RemoveEntry, so RemoveEntry always removes an entry.

OTOH, nsBaseHashtable::Remove accepts a key and returns a bool as desired by the bug description.

Unless I misunderstand something here, I think this can be resolved.

Comment 3

[Simon Giesecke [:sg] [he/him]]

Also, nsTHashtable::EnsureRemoved has the property you ask for.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Resolving sounds great, 14 years :)

Comment 5

[Simon Giesecke [:sg] [he/him]]

All's well that ends well ;)