271373 - Bogus t/008filter.t error on Win32

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Marc Schumann [:Wurblzap]]

On Win32, t/008filter.t fails when checking sidebar.xul.tmpl. The reason is that
filter exceptions for files not containing a slash in their name are forgotten
in the Win32-specific part of t/008filter.t that converts slashes to backslashes.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[:glob ✱]

Comment on attachment 166844 [details] [diff] [review]
Patch

yup, looks good.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 166844 [details] [diff] [review]
Patch

Gerv wrote this originally I think, and I'm not quite following what's going on
here...   just want Gerv to double-check it.

Comment 4

[Gervase Markham [:gerv]]

I didn't write the Win32-specific bit. This fix looks fine, but the reason for
the  next is a bit subtle. I'd prefer:

if ($file ne $orig_file) {
  delete $safe{$orig_file};
}

which is much more self-documenting.

Gerv

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.2

I made that

if ($file ne $orig_file) {
  $safe{$file} = $safe{$orig_file};
  delete $safe{$orig_file};
}

Comment 6

[Marc Schumann [:Wurblzap]]

Comment on attachment 168008 [details] [diff] [review]
Patch 1.2

I'm unsure whether to move the r+ forward or not...

Comment 7

[:glob ✱]

Comment on attachment 168008 [details] [diff] [review]
Patch 1.2

r=glob

Comment 8

[Vlad Dascalu]

Checking in t/008filter.t;
/cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v  <--  008filter.t
new revision: 1.17; previous revision: 1.16
done

Checking in t/008filter.t;
/cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v  <--  008filter.t
new revision: 1.12.2.1; previous revision: 1.12
done