271426 - BrowserHome(); no longer displays home page

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[David E. Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122

BrowserHome(); was the call-back for requesting the user's home page.  This
call-back no longer works.  This invalidates extensions that used the call-back
(e.g., PrefBar).  

Reproducible: Always
Steps to Reproduce:
1.  Install PrefBar 2.3.1 and relaunch Mozlla.  
2.  Configure PrefBar to have a Home button with the onClick value of BrowserHome();
3.  Browse to any Web page that is not the home page identified in your
preferences.  
4.  Select the Home button on the PrefBar toolbar.  

Actual Results:  
No response.  

Expected Results:  
Home page should appear.  

While the problem manifests itself while using an extension, the cause of the
problem is that an internal Mozilla interface changed.  Thus, this is a Mozilla
problem.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is due to the change in bug 267169 -- BrowserHome() now takes an event
argument that seems to be required to specify what the target browser is.

Comment 2

[David E. Ross]

If the change cited in comment #1 is not reversed, then the installation notes
for Mozilla 1.8 must describe this change with sufficient detail so that
appropriate modifications can be made not only by extension developers but also
by extension users.  

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

make browserhome work if no event is passed to it

Comment 4

[[e-mail]]

Fix checked in.