27144 - With no body content, editor adds a br moz_editor element in Page source

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Chris Petersen]

Build: Apprunner
Version: 2000020908

Platforms: All

Expected Results:
In Page source, the body element should not contain any additional elements.

What I got: In Page source, a unique element (br moz_editor) displays in the body 
element.

Steps to reproduce:

1) Open the attached file in Editor.

2) Save file to local hard drive.

3) Select Page source from View menu.

4) Notice the new element nested in body element.

Comment 1

[Chris Petersen]

Attachment: A simple html file with no additional body content.

Comment 2

[Akkana Peck]

Page Source in the editor is currently not really implemented at this point (it
does what view source in the browser does, which is wrong since it won't pick up
any changes the user has made); but I think I have a way of implementing it
quickly, which will require a save and should take care of hiding the moz
special elements.

... or it might not, because I don't see this.  I tried "mozilla -edit
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=5113" to edit the
attachment in this bug report, then I did view source, and I didn't see any moz
special br nodes.  I don't see it when starting with a blank page, either. 
Phil, please give me instructions on how you saw this so I can test it when I
implement View Source in the editor.

Marking M15 though there's a good chance I'll have an implementation sooner.

Comment 3

[Chris Petersen]

Here's the way I can reproduce it:

1) Open test case in apprunner.

2) Select edit page from file menu.

3) In Editor, select save as. Save the file locally.

4) Select Page source from View menu.

5) Page source displays the br moz_editor nested in body.

Comment 4

[Akkana Peck]

Ah, I see -- the Save As changes the file's idea of its URL, so View Source is
coming up on a different URL than if you don't first View Source.  Now I see it.

Adding Joe because I thought all our special tags were supposed to start with an
underscore, and moz_editor_bogus_node="TRUE" is new and not something that the
output system knows to strip out (it current strips out _moz).  Joe, what's up
with 'br moz_editor_bogus_node="TRUE"'?

Comment 5

[Joe Francis]

beats me.  lets underscore it.

Comment 6

[Akkana Peck]

Fixed -- now it's called _moz_editor_bogus_node and the output system will strip
out any attribute that starts with _moz.

Comment 7

[Chris Petersen]

Fixed in the Feb 23 build (2000022308).