Closed
Bug 271475
Opened 20 years ago
Closed 20 years ago
nsINIParser::Init is noisy when given file doesn't exist
Categories
(Toolkit :: Startup and Profile System, defect)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
Attachments
(1 file)
|
877 bytes,
patch
|
benjamin
:
first-review+
|
Details | Diff | Splinter Review |
nsINIParser::Init is noisy when given file doesn't exist Either we should eliminate the NS_ENSURE_ macro, or we should fix the callers to check if the file exists before passing it to nsINIParser. I think removing the NS_ENSURE_ macro is probably fine. BTW, this warning is hit by the nsXREDirProvider when it is trying to populate the various directory lists. It tries to read components.ini from various locations, but those files don't always exist.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #166895 -
Flags: first-review?(bsmedberg)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 166895 [details] [diff] [review] v1 patch I guess this is ok. I wanted clients of this API to do an Exists() check, but I suppose that's placing an unnecessary burden on the calling code.
Attachment #166895 -
Flags: first-review?(bsmedberg) → first-review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Well, I figured you intended not to have callers check Exists() since that's how you coded things with your semi-single profile patch ;-)
|
|
Assignee | |
Comment 4•20 years ago
|
||
ack.. i almost forgot about this patch. fixed-on-trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Updated•18 years ago
|
Flags: in-testsuite-
Component: XRE Startup → Startup and Profile System
QA Contact: nobody → startup
You need to log in
before you can comment on or make changes to this bug.
Description
•