271496 - [Mac] both delete and del keys should delete bookmarks and history items

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Wayne Woods]

In the Mac OS X version, in the bookmarks manager, the key to delete bookmarks
should be intuitively either delete or cmd-delete. It's currently set to cmd-d.

While it doesn't violate the Apple HIG, cmd-d is usually used for other things
in OS X. Delete is commonly used to delete items from lists (such as the
bookmarks manager in Safari, or mails in Mail), so it fits this use.
Furthermore, cmd-d is used to *add* a bookmark in the main browser window, so it
doesn't make sense for it to do the opposite in the bookmarks manager.

This is a duplicate of Mozilla Seamonkey bug 26543. I figured that Firefox would
probably require its own patch. If that's wrong, sorry for the bugspam, please
dupe it.

Comment 1

[Asaf Romano (gone)]

I should use bookmarks a bit more :) Cmd+D for delete!? The undo function is the
only reason it isn't a daatalose issue. On mac, this is expected to dupe the
selected item (I'm also not sure if ctrl+d is the expected keybinding on windows).

Anyway questions for front-end reviewers: do we want a duplicate function in the
Bookmarks manager? IMO no. Maybe on mac only?

Comment 2

[u49640]

> (I'm also not sure if ctrl+d is the expected keybinding on windows)

no, i'd try "Del" first.

btw: isnt ctrl+d Add to Bookmark? so deleting them with the same Shortcut isnt
the best of all ideas ;)

I'd suggest changing it to ALL, since it should be "Del" on Windows too (no idea
what it should be on Linux, but i'd guess it should be Del there too)

Comment 3

[Wayne Woods]

Yes, it probably should be changed to del on Windows and Linux too. The
Seamonkey equivalent - bug 26543 - also covers all platforms.

The clash of uses for cmd-d (or ctrl-d for PC), is certainly an important issue,
which I mentioned in comment 1.

cheers

Comment 4

[Asaf Romano (gone)]

dep: bug 271766

Comment 5

[ms]

Actually, I can't even use cmd-d.  The only keyboard shortcut that works for me
is cmd-x, which replaces clipboard contents.  Cmd-delete would be ever so much
better.  Some apps use a confirmation dialog with the delete, no dialog with
cmd-delete, that's a good way to support power users.

Comment 6

[Asaf Romano (gone)]

Attachment: patch - Add the missing key

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 182938 [details] [diff] [review]
patch - Add the missing key

Should this also be fixed for the history panel as well?  Under what
circumstances are the keys equal, and where are they not?

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 182938 [details] [diff] [review]
patch - Add the missing key

change the id to key_delete2, and add the same bit to history-panels.xul as
appropriate and we're in business. r=me on changes to both

Comment 9

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 182938 [details] [diff] [review]
patch - Add the missing key

a=shaver.

Comment 10

[Asaf Romano (gone)]

Checking in components/bookmarks/content/bookmarksManager.xul;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksManager.xul,v 
<--  bookmarksManager.xul
new revision: 1.28; previous revision: 1.27
done
Checking in components/history/content/history-panel.xul;
/cvsroot/mozilla/browser/components/history/content/history-panel.xul,v  <-- 
history-panel.xul
new revision: 1.32; previous revision: 1.31
done

Comment 11

[sairuh (rarely reading bugmail)]

the Delete key now deletes the selected item in the Bookmarks Manager and the
History Sidebar (but not the Bookmarks Sidebar). vrfy'd fixed with
2005060807-trunk deer park bits on OS X 10.4.1.

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change