271567 - Add back onload XPInstall

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Mike Kaply [:mkaply]]

Now that we have XPInstall whitelisting, it doesn't make any sense to block
onload XPIs anymore.

We should add them back.

Comment 1

[Daniel Veditz [:dveditz]]

For the trunk onload blocking is the only thing active right now. We need a
whitelisting UI for the Suite before it makes sense to turn on the whitelisting,
and we need to turn on whitelisting before it makes sense to fix this one.

But, we should do all of the above.

Comment 2

[Mike Kaply [:mkaply]]

Any traction on this?

Also see:

https://bugzilla.mozilla.org/show_bug.cgi?id=263872

Comment 3

[Daniel Veditz [:dveditz]]

*** Bug 296175 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Veditz [:dveditz]]

Attachment: Don't block onload installs

Comment 5

[Scott MacGregor]

Comment on attachment 194513 [details] [diff] [review]
Don't block onload installs

We're removing code that we had intentionally added back before Firefox had per
site white listing.

Comment 6

[Daniel Veditz [:dveditz]]

Fix checked into trunk

Comment 7

[Asa Dotzler [:asa]]

after this is verified on the trunk, we'll consider for branch approval.

Comment 8

[zug_treno]

Is XPInstall whitelisting enabled in SeaMonkey? It seems that the
'xpinstall.whitelist.required' default is 'false' in SeaMonkey/20050901. 

Comment 9

[Bob Clary [:bc] (inactive)]

Attachment: testcase

testcase: install Spider from bclary.com in onload. In Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050902 Firefox/1.6a1 this shows the
yellow info bar if the site is not whitelisted, and shows the install dialog if
the site is whitelisted.

Comment 10

[Tracy Walker [:tracy]]

verified with bc testcase on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.9a1) Gecko/20050902 Firefox/1.6a1

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 194513 [details] [diff] [review]
Don't block onload installs

Let's get this landed on the branch ASAP. Thanks!

Comment 12

[Daniel Veditz [:dveditz]]

(In reply to comment #8)
> Is XPInstall whitelisting enabled in SeaMonkey? It seems that the
> 'xpinstall.whitelist.required' default is 'false' in SeaMonkey/20050901. 

SeaMonkey has not turned on whitelisting primarily because without the infobars
there's no simple way to add a site to the whitelist. Given the problems in bug
295058 we can't put this off any longer on SeaMonkey's account hoping for the
day someone steps up and implements infobars. (bug 295058 afflicts SeaMonkey as
well).

Comment 13

[Daniel Veditz [:dveditz]]

Fixed on 1.8 branch