271590 - edit group controls fails miserably if no product parameter is passed

Status: RESOLVED DUPLICATE of bug 240250

(Bugzilla :: Administration, task)

Description

[timeless]

Software error:

DBD::mysql::st execute failed: You have an error in your SQL syntax.  Check the
manual that corresponds to your MySQL server version for the right syntax to use
near 'JOIN bug_group_map ON bug_group_map.group_id = groups.id LEFT J [for
statement ``SELECT id, name, entry, membercontrol, othercontrol, canedit,
isactive, COUNT(bugs.bug_id) FROM groups LEFT JOIN group_control_map ON
group_control_map.group_id = id AND group_control_map.product_id =  LEFT JOIN
bug_group_map ON bug_group_map.group_id = groups.id LEFT JOIN bugs ON
bugs.bug_id = bug_group_map.bug_id AND bugs.product_id =  WHERE isbuggroup != 0
AND (isactive != 0 OR entry IS NOT NULL OR bugs.bug_id IS NOT NULL) GROUP BY
name'']) at Bugzilla/DB.pm line 66
	Bugzilla::DB::SendSQL('SELECT id, name, entry, membercontrol, othercontrol,
canedit, is...') called at /opt/webtools/bugzilla/editproducts.cgi line 1281

For help, please send mail to the webmaster ([e-mail]), giving this
error message and the time and date of the error.

Comment 1

[Dave Miller [:justdave]]

The URL specified as generating the error is not linked to from anywhere, so no
reasonable admin would ever run into this error without hand-manipulating the URL.

That said, however, it should throw a polite error stating that you haven't
chosen a product instead of trying to run SQL with a null product_id variable.

Comment 2

[Frédéric Buclin]

This is a dupe of a bug already opened by.... timeless ;)

I have a trivial patch for this. I will submit it today in bug 240250.

*** This bug has been marked as a duplicate of 240250 ***