271644 - crash at [@ nsFolderCompactState::ShowDoneStatus] when compacting folders

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Asa Dotzler [:asa]]

When compacting folders on one of my IMAP accounts (using the File -> Compact
folders menu item) I got this crash:

nsFolderCompactState::ShowDoneStatus 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 461]
nsFolderCompactState::CompactNextFolder 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 498]
nsFolderCompactState::OnStopRunningUrl 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 346]
nsUrlListenerManager::OnStopRunningUrl 
[/mailnews/base/src/nsUrlListenerManager.cpp, line 123]
nsImapMailFolder::SetUrlState  [/mailnews/imap/src/nsImapMailFolder.cpp, line 6067]
XPTC_InvokeByIndex  [/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 102]
EventHandler  [/xpcom/proxy/src/nsProxyEvent.cpp, line 545]
shdocvw.dll + 0x150c24 (0x778b0c24)
nsBaseCommandController::nsBaseCommandController 
[/embedding/components/commandhandler/src/nsBaseCommandController.cpp, line 60]
0x10ff016a

This happened with my branch nightly build from yesterday (2004112312) and it
happened right after I did quick select all and delete from several IMAP folders
and a saved search folder then a trash empty from the File menu (then the
compact folders action).

There are a couple dozen similar incidents in talkback happening on both Windows
and Linux. About 10 of those belong to one person who seems to be hitting it
randomly but frequently (do we do some kind of auto-compacting during a normal
session?) 

This only seems to have incidents from the last 2 days' builds so it might be a
recent regression. First incident shows up using 11-23 bits.

Comment 1

[Asa Dotzler [:asa]]

Setting as a blocker to make sure this doesn't slip our radar. Scott, or David,
feel free to minus this if you don't think it's a serious concern.

Comment 2

[Scott MacGregor]

probably from Bug #181627

Comment 3

[Asa Dotzler [:asa]]

I see a checkin related to compacting at bug 181627 that fits the timeframe.
Possibly related. 

Comment 4

[David :Bienvenu]

yes, that's mine - fix upcoming...

Comment 5

[Asa Dotzler [:asa]]

Possibly related, I'm seeing in talkback data a number of crashes at
nsFolderCompactState::FinishCompact going back to 0.9. Those have stacks that
look like this:

nsFolderCompactState::FinishCompact 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 434]
nsFolderCompactState::StartCompacting 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 365]
nsFolderCompactState::CompactNextFolder 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 495]
nsFolderCompactState::FinishCompact 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 440]
nsFolderCompactState::OnStopRequest 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 532]
nsMsgProtocol::OnStopRequest  [/mailnews/base/util/nsMsgProtocol.cpp, line 362]
nsMailboxProtocol::OnStopRequest  [/mailnews/local/src/nsMailboxProtocol.cpp,
line 392]
nsInputStreamPump::OnStateStop  [/netwerk/base/src/nsInputStreamPump.cpp, line 499]
0x047bbeb8
nsMailboxProtocol::`vftable'
nsMsgProtocol::AddRef  [/mailnews/base/util/nsMsgProtocol.cpp, line 68]
0x8b560c45

I suspect this could be an older bug. If it's not related to the problem here,
should I file a new bug on it?

Comment 6

[Asa Dotzler [:asa]]

most of the comments for the nsFolderCompactState::FinishCompact crash actually
say "Compacting folders" or similar where the
nsFolderCompactState::ShowDoneStatus crashes don't.

Comment 7

[David :Bienvenu]

sure, file a new bug on that one...on me.

Comment 8

[David :Bienvenu]

Attachment: proposed fix

Comment 9

[Asa Dotzler [:asa]]

new bug is bug 271645

Comment 10

[David :Bienvenu]

fix was checked in a couple days ago.

Comment 11

[Jay Patel [:jay]]

v.fixed based on Talkback data, no crashes since 11/25