271645 - crash compacting folders with [@ nsFolderCompactState::FinishCompact]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Asa Dotzler [:asa]]

Talkback has quite a few incidents on nsFolderCompactState::FinishCompact and
almost all of the comments say that the user was compacting folders. This looks
like one of the more common 0.9 crashers still showing up in nightly data. It
seems to affect at least Linux and Windows.

nsFolderCompactState::FinishCompact 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 434]
nsFolderCompactState::StartCompacting 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 365]
nsFolderCompactState::CompactNextFolder 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 495]
nsFolderCompactState::FinishCompact 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 440]
nsFolderCompactState::OnStopRequest 
[/mailnews/base/src/nsMsgFolderCompactor.cpp, line 532]
nsMsgProtocol::OnStopRequest  [/mailnews/base/util/nsMsgProtocol.cpp, line 362]
nsMailboxProtocol::OnStopRequest  [/mailnews/local/src/nsMailboxProtocol.cpp,
line 392]
nsInputStreamPump::OnStateStop  [/netwerk/base/src/nsInputStreamPump.cpp, line 499]
0x047bbeb8
nsMailboxProtocol::`vftable'
nsMsgProtocol::AddRef  [/mailnews/base/util/nsMsgProtocol.cpp, line 68]
0x8b560c45

Comment 1

[Rinaldi J. Montessi]

I'm seeing this in todays CVS build of Moz 1.8a6.

 --enable-application=suite --enable-default-toolkit=gtk2 --enable-xft
--disable-freetype2 --enable-crypto --enable-optimize=-O2 

Since I didn't enable debug all I get is a segfault on Compact Folders

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Comment 3

[David :Bienvenu]

Comment on attachment 167136 [details] [diff] [review]
proposed fix

bullet-proofing fix.

Comment 4

[David :Bienvenu]

bullet-proofing fix checked in.