271711 - Virtual folders can't use international characters in folder name.

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Anders]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Thunderbird 0.9+ 20041124

If you create a virtual folder and give it a name "Inbox-åäö" the name will be
garbled for the three characters åäö. 

Reproducible: Always
Steps to Reproduce:
1. Performe a search
2. Save search as a folder
3. Give the folder the name "Inbox-åäö"

Actual Results:  
A folder with the name "Inbox-&AOUA5AD2-" appears.

Expected Results:  
The name should be "Inbox-åäö"

Comment 1

[Anders]

Ok, how about making bugzilla characterset aware? Anyway, the name should be
Inbox-едц (htmlentities åäö

Comment 2

[Anders]

I created a regular folder with the name "åke" and get a "&AOU-ke.sbd" folder in
my profile folder. If I make a virtual folder with the same name (after deleting
the regular folder) it gets exactly the same name. So folder creation is ok, but
when the name is displayed in the "Folders"-pane. The regular folder is
displayed correctly "åke" but the saved search folder is displayed as "&AOU-ke"

Hope this helps.

Comment 3

[Scott MacGregor]

this is a respin level bug. we should fix this.

Comment 4

[Scott MacGregor]

Attachment: the fix

Comment 5

[Scott MacGregor]

Comment on attachment 167593 [details] [diff] [review]
the fix

David, in debugging this, I couldn't see anyone setting  an explicit folder
name as I stepped through the nsMsgFolder::AddSubFolder code. So the name of
the folder was always the escaped name. My fix was to explictly set the pretty
name after we create the folder. You might want to double check my logic on
this being the right way to fix this.

Comment 6

[Scott MacGregor]

alternatively maybe we shouldn't calling AddSubFolder here at all. Maybe we
should go through ::CreateSubFolder which goes through all sorts of methods like
nsMsgI18NConvertFromUnicode on the passed in folder name in addition to calling
SetPrettyName.

AddSubFolder just NS_MsgEscapeEncodeURLPath and uses that as the name of the
folder and I believe the name of the file on disk.

Comment 7

[David :Bienvenu]

Comment on attachment 167593 [details] [diff] [review]
the fix

I like this fix - it seems a lot safer.

Comment 8

[Scott MacGregor]

fixed branch and trunk

Comment 9

[Tracy Walker [:tracy]]

verified with Windows XP TB build 2004-12-02-11-0.9