271731 - Get Sunbird ready for Theme Manager

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

FF and TB use the same UID for their default theme. This UID is referenced in
toolkit theme code (for example 
toolkit/mozapps/extensions/src/nsExtensionManager.js.in)

Sunbird's default theme UID is unique from the FF/TB UID, and bringing it in
line with FF/TB's will let us use some toolkit theme code as is.

This should be a trunk only fix.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - patch adds updated theme directory

In addition to applying this, remove the directory and its contents:
mozilla/calendar/sunbird/app/profile/extensions/{8af2d0a7-e394-4de2-ae55-2dae532a7a9b}

Comment 2

[Matthew (lilmatt) Willis]

Attachment: icon for themes manager

check in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/icon.png

Comment 3

[Matthew (lilmatt) Willis]

Attachment: preview image for theme manager

check in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/preview.png

Comment 4

[Matthew (lilmatt) Willis]

Per shaver, CCing justdave for scripts to help moving directories without losing
cvs blame.

mostafah: Don't delete the {8.... directory, but instead we'll use cvs rename
(or something) so as to no lose cvs blame

Comment 5

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - added to classic.jar in pinstripe for theme manager

Comment 6

[Matthew (lilmatt) Willis]

Attachment: Screenshot of updated pinstripe theme manager in Sunbird

Comment 7

[Dave Miller [:justdave]]

(In reply to comment #4)
> Per shaver, CCing justdave for scripts to help moving directories without losing
> cvs blame.

What directories are we moving?  I need a source and destination for the move,
and an sr= on the move.

Comment 8

[Matthew (lilmatt) Willis]

(In reply to comment #7)
> What directories are we moving?  I need a source and destination for the move,

Source:
mozilla/calendar/sunbird/app/profile/extensions/{8af2d0a7-e394-4de2-ae55-2dae532a7a9b}

Destination:
mozilla/calendar/sunbird/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}

> and an sr= on the move.

Mostafa: could you give the sr? Once the directory is moved in cvs, I'll
recreate the rev1 patch above only changing what we need. The icon and preview
images can be checked in now -- they're still valid and their paths will not change.

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 167114 [details] [diff] [review]
rev1 - trunk - added to classic.jar in pinstripe for theme manager

Removing request for review. I will make a new patch once the existing files
are moved, to keep cvs blame info.

Comment 10

[Mostafa Hosseini]

(In reply to comment #8)
> Mostafa: could you give the sr? Once the directory is moved in cvs, I'll
> recreate the rev1 patch above only changing what we need. The icon and preview
> images can be checked in now -- they're still valid and their paths will not
change.

sr=mostafa for the move

Comment 11

[Matthew (lilmatt) Willis]

justdave:
Reminder we need the cvs move and mostafa has given his sr for it.

Comment 12

[Matthew (lilmatt) Willis]

justdave: Updating the bug to remind you that we need this move.

> Source:
>
mozilla/calendar/sunbird/app/profile/extensions/{8af2d0a7-e394-4de2-ae55-2dae532a7a9b}
> 
> Destination:
>
mozilla/calendar/sunbird/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}

> sr=mostafa for the move

Comment 13

[Dave Miller [:justdave]]

CVS copy has been completed.  The destination directory and the two files in it
(Makefile.in and install.rdf.in) exist ONLY on the trunk.  If you need it to
exist on a branch, you will need to re-branch the files.  You will need to cvs
remove the two files from the old location once you no longer need them.  CVS
can't actually remove directories, but if you use -P on your cvs update (after
the two files are removed), the newly-empty directory will go away.

Comment 14

[Matthew (lilmatt) Willis]

Attachment: rev2 - trunk - updates files to new UID

This patch no longer has the "remove/add" method of moving the directory.
justdave took care of that for us.

Comment 15

[Matthew (lilmatt) Willis]

Attachment: rev1 - icon for themes manager (crushed)

Comment 16

[Matthew (lilmatt) Willis]

Attachment: rev1 - preview image for themes manager (crushed)

Comment 17

[Matthew (lilmatt) Willis]

Attachment: rev3 - trunk - also removes old files

Use the -P flag when committing this to "prune" the {8... directory from CVS

Comment 18

[Dave Miller [:justdave]]

(In reply to comment #17)
> Use the -P flag when committing this to "prune" the {8... directory from CVS

-P isn't used when you commit, that's a checkout/update thing.

Comment 19

[Matthew (lilmatt) Willis]

(In reply to comment #18)
> (In reply to comment #17)
> > Use the -P flag when committing this to "prune" the {8... directory from CVS
> 
> -P isn't used when you commit, that's a checkout/update thing.

My bad. Thanks.

Comment 20

[Matthew (lilmatt) Willis]

Patch and gfx checked in. 

Comment 21

[Simon Paquet [:sipaq]]

Matthew, we still need icons and imagery for Windows/Linux (Winstripe).
Reopening and CC'ing Mark Carson for this.

Comment 22

[Matthew (lilmatt) Willis]

Attachment: rev0 - First cut at winstripe icon.png

Comment 23

[Matthew (lilmatt) Willis]

Attachment: rev0 - first cut at winstripe preview.png, patterned after Firefox

Comment 24

[Matthew (lilmatt) Willis]

Attachment: rev0 - adds icon.png and preview.png to winstripe's jar.mn

Comment 25

[Matthew (lilmatt) Willis]

Mark,
Consider these images placeholders. I can hook you up with the .psd files as
well if you'd like. (I actually would like to start putting them in cvs.)

One thing of note: Your icons are all at 100dpi, while other elements (such as
Firefox's icon.png) is at 72dpi, so your icons look a little smaller.

Comment 26

[Matthew (lilmatt) Willis]

Winstripe icon.png preview.png and jar.mn patch checked in

Changing Summary
-> FIXED

If Mark makes new icons, we'll reopen this

Comment 27

[Mark Carson]

Attachment: Default Sunbird Theme icon (32x32 image) [checked in]

32x32 icon to be used by the theme manager in Sunbird to denote the default
(Winstripe) theme.

Comment 28

[Mark Carson]

Attachment: Default Sunbird Theme icon (32x32 image) - PSD

32x32 icon to be used by the theme manager in Sunbird to denote the default
(Winstripe) theme.

PSD (Photoshop) version

Both version of the image are 72dpi and have transparent background and partial
transparency drop shadowing. Calendar is larger than what is used in the
toolbar.

Comment 29

[Mark Carson]

Preview image looks fine to me. I have uploaded a new "icon.png" file in both
PNG and PSD formats at 72dpi with transparency. This is the image to be used by
the theme manager to the left of the theme name. The image is a new creation
(not an extract from the large toolbar) but used the month view icon metaphor
(without any sub-icons). If something else is needed, let me know.

Comment 30

[Matthew (lilmatt) Willis]

Comment on attachment 169690 [details]
Default Sunbird Theme icon (32x32 image) [checked in]

checked in. 
thanks Mark!

Comment 31

[Matthew (lilmatt) Willis]

mostafah:

I'd like to have a place in cvs to put .psd (Photoshop) files of the graphics
It obviously wouldn't be included in a release, but would add a little bit to
folks checking out the source.

Do you have either an objection, or a suggestion as to where?

Comment 32

[Mostafa Hosseini]

(In reply to comment #31)
> mostafah:
> 
> I'd like to have a place in cvs to put .psd (Photoshop) files of the graphics
> It obviously wouldn't be included in a release, but would add a little bit to
> folks checking out the source.
> 
> Do you have either an objection, or a suggestion as to where?

My objection to this is that having .psd files in CVS is something no other
Mozilla project is practicing.I suggest using bugzilla for trading .psd files
for now.

Comment 33

[Matthew (lilmatt) Willis]

(In reply to comment #32)
> (In reply to comment #31)
> > mostafah:
> > 
> > I'd like to have a place in cvs to put .psd (Photoshop) files of the graphics
> > It obviously wouldn't be included in a release, but would add a little bit to
> > folks checking out the source.
> > 
> > Do you have either an objection, or a suggestion as to where?
> 
> My objection to this is that having .psd files in CVS is something no other
> Mozilla project is practicing.I suggest using bugzilla for trading .psd files
> for now.

The problem with that is when .psd files run over the 300k limit of bugzilla.

Comment 34

[Mostafa Hosseini]

> The problem with that is when .psd files run over the 300k limit of bugzilla.
> 

I guess that (large file size ) is a reason for not having .psd files in CVS as
well. How do other projects handle this need?

Comment 35

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!