271802 - nsPrintDialogUtil.cpp uses a localizable string for a preference

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Mike Connor [:mconnor]]

Spun off from bug 271470

http://lxr.mozilla.org/mozilla/source/embedding/tests/mfcembed/components/nsPrintDialogUtil.cpp#903
http://lxr.mozilla.org/mozilla/source/embedding/components/printingui/src/win/nsPrintDialogUtil.cpp#914

bug 78319 comment 80 seems to indicate this was done for a fallback, but I don't
think there's any current need for a fallback, especially as I think all Firefox
translations seem to be fine with using the extended dialog.

We should probably just trash this code and always use the extended dialog, or
convert this to a pref-based item so that we can disable the frames thing
per-app instead of per-language (i.e. Thunderbird probably doesn't need UI for
printing frames, nor would a random embedding app).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This should block aviary 1.1 to reduce the number of localization train wrecks.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: untested patch

This is completely untested; I don't have a Windows build environment.	If
someone could make it compile and test it, that would be great!

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 175529 [details] [diff] [review]
untested patch

Since you seem (per comments on bug 271470) to prefer this approach, any chance
you could test and review this?

Comment 4

[Benjamin Smedberg]

*** Bug 271470 has been marked as a duplicate of this bug. ***

Comment 5

[Benjamin Smedberg]

Comment on attachment 175529 [details] [diff] [review]
untested patch

WFM.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

so why not just always show the dialog?

Comment 7

[Benjamin Smedberg]

I don't know, but there might be a reason having to do with localized Windows?

Comment 8

[Benjamin Smedberg]

Fixed on trunk for 1.8b3

Comment 9

[u60234]

The "extend=true" string in printdialog.properties is still there. Was that part
of the patch not checked in?

Comment 10

[Stefan [:stefanh]]

(In reply to comment #9)
> The "extend=true" string in printdialog.properties is still there. Was that part
> of the patch not checked in?

Looks like that:
http://lxr.mozilla.org/seamonkey/source/dom/locales/en-US/chrome/printdialog.properties#45

Comment 11

[Stefan [:stefanh]]

 
> Looks like that:
>
http://lxr.mozilla.org/seamonkey/source/dom/locales/en-US/chrome/printdialog.properties#45

Err, I meant that it was never checked in for some reason...

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I checked in the missed change on the trunk.  Not sure whether we want it on the
branch at this point as well.

Comment 13

[Benjamin Smedberg]

Let's leave it on the branch, it's not going to hurt anyone no matter how it's
translated.