Spun off from bug 271470 http://lxr.mozilla.org/mozilla/source/embedding/tests/mfcembed/components/nsPrintDialogUtil.cpp#903 http://lxr.mozilla.org/mozilla/source/embedding/components/printingui/src/win/nsPrintDialogUtil.cpp#914 bug 78319 comment 80 seems to indicate this was done for a fallback, but I don't think there's any current need for a fallback, especially as I think all Firefox translations seem to be fine with using the extended dialog. We should probably just trash this code and always use the extended dialog, or convert this to a pref-based item so that we can disable the frames thing per-app instead of per-language (i.e. Thunderbird probably doesn't need UI for printing frames, nor would a random embedding app).
This should block aviary 1.1 to reduce the number of localization train wrecks.
Created attachment 175529 [details] [diff] [review] untested patch This is completely untested; I don't have a Windows build environment. If someone could make it compile and test it, that would be great!
Comment on attachment 175529 [details] [diff] [review] untested patch Since you seem (per comments on bug 271470) to prefer this approach, any chance you could test and review this?
*** Bug 271470 has been marked as a duplicate of this bug. ***
Comment on attachment 175529 [details] [diff] [review] untested patch WFM.
so why not just always show the dialog?
I don't know, but there might be a reason having to do with localized Windows?
Fixed on trunk for 1.8b3
The "extend=true" string in printdialog.properties is still there. Was that part of the patch not checked in?
(In reply to comment #9) > The "extend=true" string in printdialog.properties is still there. Was that part > of the patch not checked in? Looks like that: http://lxr.mozilla.org/seamonkey/source/dom/locales/en-US/chrome/printdialog.properties#45
> Looks like that: > http://lxr.mozilla.org/seamonkey/source/dom/locales/en-US/chrome/printdialog.properties#45 Err, I meant that it was never checked in for some reason...
I checked in the missed change on the trunk. Not sure whether we want it on the branch at this point as well.
Let's leave it on the branch, it's not going to hurt anyone no matter how it's translated.