Closed Bug 271814 Opened 20 years ago Closed 20 years ago

build bustage VS6 in nsSVGUseElement.cpp

Categories

(Core :: SVG, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: daa, Assigned: jwatt)

Details

Attachments

(1 file)

building under MS VS6, build fails with :

 d:/mozsvg/mozilla/content/svg/content/src/nsSVGUseElement.cpp(524) : error 
C2374  : 'i' : redefinition; multiple initialization
 d:/mozsvg/mozilla/content/svg/content/src/nsSVGUseElement.cpp(509) : see
  declaration of 'i'

looks like VS6 does not like args in "for" defined in the statement
Attached patch patchSplinter Review
Assignee: tor → jonathan.watt
Status: NEW → ASSIGNED
Severity: normal → critical
Comment on attachment 167084 [details] [diff] [review]
patch

r+ on this trivial fix, follows our code guidelines to fix that for-loop.

I am not a peer of course, though was around IRC and will try and get someone
to comit.
Attachment #167084 - Flags: review+
timeless comitted
Severity: critical → normal
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You knocked the severity to normal when you made that last comment, returning to
critical. :)
Severity: normal → critical
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: