271824 - do_GetFastLoadService should use nsGetServiceByCID

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bernard Alleysson]

Let do_GetFastLoadService() take advantage of the improvements after bug 264456

Comment 1

[Bernard Alleysson]

Attachment: use nsGetServiceByCID

Comment 2

[Bernard Alleysson]

Comment on attachment 167092 [details] [diff] [review]
use nsGetServiceByCID

Brian, would you review the patch ? It makes do_GetFastLoadService()
use the new improved nsGetServiceByCID

Comment 3

[Darin Fisher]

Comment on attachment 167092 [details] [diff] [review]
use nsGetServiceByCID

same issue with do_GetIOService.  is this really worth it?

Comment 4

[Bernard Alleysson]

Attachment: remove static variable duplication

In fact do_GetFastLoadService(&rv) is not used, it can be removed

Comment 5

[Benjamin Smedberg]

Comment on attachment 168952 [details] [diff] [review]
remove static variable duplication

Why are we using a CID instead of a contractid?

Comment 6

[Darin Fisher]

Comment on attachment 168952 [details] [diff] [review]
remove static variable duplication

sure, sr=darin (though i agree that a ContractID is probably preferred)

Comment 7

[Doug Turner (:dougt)]

yeah, using a CID in an IDL, that is just evil.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Seems like this patch was forgotten. Should the issue from comment 5 be addressed?

Comment 9

[jag (Peter Annema)]

Attachment: Use *ByContractID

Note that the WithError version is now being used. Also, while I was looking into this I noticed a few places that were including the .h file unnecessarily.

Comment 10

[jag (Peter Annema)]

Comment on attachment 277071 [details] [diff] [review]
Use *ByContractID

*bsmedberg* oh, you can count me as r+sr

Requesting a1.9. Trivial fix, saves a few bytes.

Comment 11

[jag (Peter Annema)]

Checking in content/xul/document/src/nsXULContentSink.cpp;
/cvsroot/mozilla/content/xul/document/src/nsXULContentSink.cpp,v  <--  nsXULContentSink.cpp
new revision: 1.185; previous revision: 1.184
done
Checking in content/xul/document/src/nsXULDocument.cpp;
/cvsroot/mozilla/content/xul/document/src/nsXULDocument.cpp,v  <--  nsXULDocument.cpp
new revision: 1.782; previous revision: 1.781
done
Checking in content/xul/document/src/nsXULDocument.h;
/cvsroot/mozilla/content/xul/document/src/nsXULDocument.h,v  <--  nsXULDocument.h
new revision: 1.201; previous revision: 1.200
done
Checking in js/src/xpconnect/loader/mozJSComponentLoader.h;
/cvsroot/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.h,v  <--  mozJSComponentLoader.h
new revision: 1.30; previous revision: 1.29
done
Checking in xpcom/io/nsIFastLoadService.idl;
/cvsroot/mozilla/xpcom/io/nsIFastLoadService.idl,v  <--  nsIFastLoadService.idl
new revision: 3.12; previous revision: 3.11
done

and bustage fix (oops):

Checking in nsXULContentSink.cpp;
/cvsroot/mozilla/content/xul/document/src/nsXULContentSink.cpp,v  <--  nsXULContentSink.cpp
new revision: 1.186; previous revision: 1.185
done