271855 - [patch] Fix mac about box

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Asaf Romano (gone)]

(This is the tb version of bug 222364, and maybe a dupe...)

The about box shoudn't be a sheet (or even app-modal/doc-modal) on mac, and
shoudn't have a close button.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

[mac only of course] this:
1. removes modal window feature on mac.
2. Uses window.open instead of window.openDialog to avoid missing
close-window-button.
3. places the extra2 button at the right side (or left in a RTL gui)

Comment 2

[Asaf Romano (gone)]

Scott, I know i'm pretty late in this game, but this one is pretty safe.

Comment 3

[Scott MacGregor]

cool I'll check this into the 1.0 branch. It's pretty low risk.

thanks for taking care of this. 

Comment 4

[Scott MacGregor]

do we need to fix up the about callers for mail compose and the address book too? 

Comment 5

[Scott MacGregor]

this patch is checked in the branch and the trunk. Leaving open for Asaf to tell
us if we need  to do anything for compose and address book...I suspect we do. 

Comment 6

[Asaf Romano (gone)]

Attachment: err, my bad

Sorry for spamming epository earlier... So this one moves openAboutDialog to
mailCore.js and fixes addressbook & compose clients.

Comment 7

[Scott MacGregor]

fixed branch and trunk

Comment 8

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2004120102-0.9 on mac os x 10.3.6.

sidenote: the version string seems to be selected (highlighted) when bringing up
the about window.

Comment 9

[Scott MacGregor]

*** Bug 272911 has been marked as a duplicate of this bug. ***

Comment 10

[Scott MacGregor]

the address book change never got checked in in the second patch for this bug. I just fixed that on the trunk. 

Comment 11

[Asaf Romano (gone)]

*Ugh*, do we happen to have more 1.5 respins?

Comment 12

[Scott MacGregor]

i checked in the addressbook change onto the 1.8.1 branch so it will be fixed in thunderbird 2.0.