Closed
Bug 271855
Opened 20 years ago
Closed 20 years ago
[patch] Fix mac about box
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird1.0
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(2 files)
2.47 KB,
patch
|
mscott
:
review+
|
Details | Diff | Splinter Review |
3.19 KB,
patch
|
Details | Diff | Splinter Review |
(This is the tb version of bug 222364, and maybe a dupe...)
The about box shoudn't be a sheet (or even app-modal/doc-modal) on mac, and
shoudn't have a close button.
Assignee | ||
Comment 1•20 years ago
|
||
[mac only of course] this:
1. removes modal window feature on mac.
2. Uses window.open instead of window.openDialog to avoid missing
close-window-button.
3. places the extra2 button at the right side (or left in a RTL gui)
Assignee: mscott → bugs.mano
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•20 years ago
|
||
Scott, I know i'm pretty late in this game, but this one is pretty safe.
Flags: blocking-aviary1.0?
Target Milestone: --- → Thunderbird1.0
Assignee | ||
Updated•20 years ago
|
Attachment #167111 -
Flags: review?(mscott)
Updated•20 years ago
|
Attachment #167111 -
Flags: review?(mscott) → review+
Comment 3•20 years ago
|
||
cool I'll check this into the 1.0 branch. It's pretty low risk.
thanks for taking care of this.
Comment 4•20 years ago
|
||
do we need to fix up the about callers for mail compose and the address book too?
Flags: blocking-aviary1.0?
Comment 5•20 years ago
|
||
this patch is checked in the branch and the trunk. Leaving open for Asaf to tell
us if we need to do anything for compose and address book...I suspect we do.
Assignee | ||
Comment 6•20 years ago
|
||
Sorry for spamming epository earlier... So this one moves openAboutDialog to
mailCore.js and fixes addressbook & compose clients.
Assignee | ||
Updated•20 years ago
|
Attachment #167138 -
Flags: review?(mscott)
Updated•20 years ago
|
Attachment #167138 -
Flags: review?(mscott)
Comment 7•20 years ago
|
||
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 8•20 years ago
|
||
vrfy'd fixed with 2004120102-0.9 on mac os x 10.3.6.
sidenote: the version string seems to be selected (highlighted) when bringing up
the about window.
Status: RESOLVED → VERIFIED
Comment 9•20 years ago
|
||
*** Bug 272911 has been marked as a duplicate of this bug. ***
Comment 10•19 years ago
|
||
the address book change never got checked in in the second patch for this bug. I just fixed that on the trunk.
Assignee | ||
Comment 11•19 years ago
|
||
*Ugh*, do we happen to have more 1.5 respins?
Comment 12•19 years ago
|
||
i checked in the addressbook change onto the 1.8.1 branch so it will be fixed in thunderbird 2.0.
Depends on: 320880
You need to log in
before you can comment on or make changes to this bug.
Description
•