271869 - unnecessary per-style-struct mBorderWidths

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

As discussed on IRC: mBorderWidths does not need to be replicated across each
Border or Outline style struct. At most there needs to be one per prescontext.

Doing this in nsRuleNode style calculation would not be correct because it would
mess up computed style values.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 167117 [details] [diff] [review]
fix

>Index: layout/base/public/nsIFrame.h

This looks like something from another patch.

Other than that, r+sr=dbaron, if you test
http://www.w3.org/Style/CSS/Test/CSS1/current/test5515.htm

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Thanks, checked in.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Seems to have reduced Tp by maybe 5ms on btek.