Closed
Bug 271869
Opened 21 years ago
Closed 21 years ago
unnecessary per-style-struct mBorderWidths
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
(Keywords: perf)
Attachments
(1 file)
|
17.59 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
As discussed on IRC: mBorderWidths does not need to be replicated across each
Border or Outline style struct. At most there needs to be one per prescontext.
Doing this in nsRuleNode style calculation would not be correct because it would
mess up computed style values.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #167117 -
Flags: superreview?(dbaron)
Attachment #167117 -
Flags: review?(dbaron)
Comment on attachment 167117 [details] [diff] [review]
fix
>Index: layout/base/public/nsIFrame.h
This looks like something from another patch.
Other than that, r+sr=dbaron, if you test
http://www.w3.org/Style/CSS/Test/CSS1/current/test5515.htm
Attachment #167117 -
Flags: superreview?(dbaron)
Attachment #167117 -
Flags: superreview+
Attachment #167117 -
Flags: review?(dbaron)
Attachment #167117 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Thanks, checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•21 years ago
|
||
Seems to have reduced Tp by maybe 5ms on btek.
You need to log in
before you can comment on or make changes to this bug.
Description
•