unnecessary per-style-struct mBorderWidths

RESOLVED FIXED

Status

()

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

({perf})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

As discussed on IRC: mBorderWidths does not need to be replicated across each
Border or Outline style struct. At most there needs to be one per prescontext.

Doing this in nsRuleNode style calculation would not be correct because it would
mess up computed style values.
Attachment #167117 - Flags: superreview?(dbaron)
Attachment #167117 - Flags: review?(dbaron)
Comment on attachment 167117 [details] [diff] [review]
fix

>Index: layout/base/public/nsIFrame.h

This looks like something from another patch.

Other than that, r+sr=dbaron, if you test
http://www.w3.org/Style/CSS/Test/CSS1/current/test5515.htm
Attachment #167117 - Flags: superreview?(dbaron)
Attachment #167117 - Flags: superreview+
Attachment #167117 - Flags: review?(dbaron)
Attachment #167117 - Flags: review+
Thanks, checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Seems to have reduced Tp by maybe 5ms on btek.

Updated

14 years ago
Keywords: perf
You need to log in before you can comment on or make changes to this bug.